summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2019-04-03 14:03:43 +0000
committerAlexander Kornienko <alexfh@google.com>2019-04-03 14:03:43 +0000
commitee737a84d75b701c2ae3a8c9a0abbae63fc330af (patch)
tree1f1c5657823c1fbde620648294137c2c0a7502b0
parentfb0e8082d412b58660f8828109d36d28088c193d (diff)
downloadbcm5719-llvm-ee737a84d75b701c2ae3a8c9a0abbae63fc330af.tar.gz
bcm5719-llvm-ee737a84d75b701c2ae3a8c9a0abbae63fc330af.zip
[clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method
Summary: All in-tree clang-tidy checks have been migrated to the new ClangTidyCheck::registerPPCallbacks method. Time to drop the old one. Reviewers: sammccall, hokein Reviewed By: hokein Subscribers: xazax.hun, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D60197 llvm-svn: 357582
-rw-r--r--clang-tools-extra/clang-tidy/ClangTidy.cpp1
-rw-r--r--clang-tools-extra/clang-tidy/ClangTidyCheck.h3
-rw-r--r--clang-tools-extra/clangd/ClangdUnit.cpp1
-rw-r--r--clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h1
4 files changed, 0 insertions, 6 deletions
diff --git a/clang-tools-extra/clang-tidy/ClangTidy.cpp b/clang-tools-extra/clang-tidy/ClangTidy.cpp
index c8a07e65982..6af8863bc9a 100644
--- a/clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -393,7 +393,6 @@ ClangTidyASTConsumerFactory::CreateASTConsumer(
for (auto &Check : Checks) {
Check->registerMatchers(&*Finder);
- Check->registerPPCallbacks(Compiler);
Check->registerPPCallbacks(*SM, PP, ModuleExpanderPP);
}
diff --git a/clang-tools-extra/clang-tidy/ClangTidyCheck.h b/clang-tools-extra/clang-tidy/ClangTidyCheck.h
index db1b270d317..fcfea90afd7 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyCheck.h
+++ b/clang-tools-extra/clang-tidy/ClangTidyCheck.h
@@ -53,9 +53,6 @@ public:
/// constructor using the Options.get() methods below.
ClangTidyCheck(StringRef CheckName, ClangTidyContext *Context);
- /// DEPRECATED: Use the other overload.
- virtual void registerPPCallbacks(CompilerInstance &Compiler) {}
-
/// \brief Override this to register ``PPCallbacks`` in the preprocessor.
///
/// This should be used for clang-tidy checks that analyze preprocessor-
diff --git a/clang-tools-extra/clangd/ClangdUnit.cpp b/clang-tools-extra/clangd/ClangdUnit.cpp
index 6bc9551abfd..24f5ca43084 100644
--- a/clang-tools-extra/clangd/ClangdUnit.cpp
+++ b/clang-tools-extra/clangd/ClangdUnit.cpp
@@ -299,7 +299,6 @@ ParsedAST::build(std::unique_ptr<CompilerInvocation> CI,
for (const auto &Check : CTChecks) {
// FIXME: the PP callbacks skip the entire preamble.
// Checks that want to see #includes in the main file do not see them.
- Check->registerPPCallbacks(*Clang);
Check->registerPPCallbacks(Clang->getSourceManager(), PP, PP);
Check->registerMatchers(&CTFinder);
}
diff --git a/clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h b/clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h
index 25409d4ca0c..33139d72c29 100644
--- a/clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h
+++ b/clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h
@@ -42,7 +42,6 @@ private:
Preprocessor *PP = &Compiler.getPreprocessor();
for (auto &Check : Checks) {
Check->registerMatchers(&Finder);
- Check->registerPPCallbacks(Compiler);
Check->registerPPCallbacks(Compiler.getSourceManager(), PP, PP);
}
return Finder.newASTConsumer();
OpenPOWER on IntegriCloud