summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Granitz <stefan.graenitz@gmail.com>2019-07-17 17:14:40 +0000
committerStefan Granitz <stefan.graenitz@gmail.com>2019-07-17 17:14:40 +0000
commitee24b40b9e9f8355f1cb6c92f6406396f9b3042d (patch)
treefb7b6f658238dd9271165f818c3db56b877d45dc
parent59532488b1d65c52aa5122bd7e191fde9a9df589 (diff)
downloadbcm5719-llvm-ee24b40b9e9f8355f1cb6c92f6406396f9b3042d.tar.gz
bcm5719-llvm-ee24b40b9e9f8355f1cb6c92f6406396f9b3042d.zip
[CMake] Avoid liblldb genex when figuring out the copy destination for framework tools
This genex created an order-only dependency to liblldb for every framework tool. It reduced build throughput in the first half of the compilation and pulled in unnecessary build units, e.g. debugserver required ~900 build units. With this change debugserver is (again) down at 52 build units! llvm-svn: 366350
-rw-r--r--lldb/cmake/modules/AddLLDB.cmake3
1 files changed, 2 insertions, 1 deletions
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index e5882329867..540d01362f0 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -199,7 +199,8 @@ endfunction()
function(lldb_add_to_buildtree_lldb_framework name subdir)
# Destination for the copy in the build-tree. While the framework target may
# not exist yet, it will exist when the generator expression gets expanded.
- set(copy_dest "$<TARGET_FILE_DIR:liblldb>/../../../${subdir}")
+ get_target_property(framework_build_dir liblldb LIBRARY_OUTPUT_DIRECTORY)
+ set(copy_dest "${framework_build_dir}/${subdir}")
# Copy into the given subdirectory for testing.
add_custom_command(TARGET ${name} POST_BUILD
OpenPOWER on IntegriCloud