summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicolas Lesser <blitzrakete@gmail.com>2019-05-05 12:15:17 +0000
committerNicolas Lesser <blitzrakete@gmail.com>2019-05-05 12:15:17 +0000
commitee0571734f58c05d2138f7c61d0bbdb928193c58 (patch)
treec5096a2b9aad7c8ffe4273d276a9758183358b38
parent60211cb8728352fcadbe56b7ab8dea6f07335c16 (diff)
downloadbcm5719-llvm-ee0571734f58c05d2138f7c61d0bbdb928193c58.tar.gz
bcm5719-llvm-ee0571734f58c05d2138f7c61d0bbdb928193c58.zip
[C++] Interpret unknown identifier in parameter clause as unknown type
instead of as parameter name without a type. llvm-svn: 359979
-rw-r--r--clang/lib/Parse/ParseDecl.cpp3
-rw-r--r--clang/test/Parser/editor-placeholder-recovery.cpp2
-rw-r--r--clang/test/SemaCXX/unknown-type-name.cpp4
3 files changed, 5 insertions, 4 deletions
diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp
index f63fd56a898..f883ecc45f1 100644
--- a/clang/lib/Parse/ParseDecl.cpp
+++ b/clang/lib/Parse/ParseDecl.cpp
@@ -2649,6 +2649,9 @@ bool Parser::ParseImplicitInt(DeclSpec &DS, CXXScopeSpec *SS,
case tok::semi:
// This looks like a variable or function declaration. The type is
// probably missing. We're done parsing decl-specifiers.
+ // But only if we are not in a function prototype scope.
+ if (getCurScope()->isFunctionPrototypeScope())
+ break;
if (SS)
AnnotateScopeToken(*SS, /*IsNewAnnotation*/false);
return false;
diff --git a/clang/test/Parser/editor-placeholder-recovery.cpp b/clang/test/Parser/editor-placeholder-recovery.cpp
index d68e087d6fb..62f5529906f 100644
--- a/clang/test/Parser/editor-placeholder-recovery.cpp
+++ b/clang/test/Parser/editor-placeholder-recovery.cpp
@@ -64,7 +64,7 @@ void avoidPlaceholderErrors(Struct &obj) {
}
}
-void Struct::method(<#Struct &x#>, noSupressionHere) { // expected-error {{unknown type name 'noSupressionHere'}} expected-error {{C++ requires a type specifier for all declarations}}
+void Struct::method(<#Struct &x#>, noSupressionHere) { // expected-error {{unknown type name 'noSupressionHere'}}
#ifndef SUPPRESS
// expected-error@-2 {{editor placeholder in source file}}
#endif
diff --git a/clang/test/SemaCXX/unknown-type-name.cpp b/clang/test/SemaCXX/unknown-type-name.cpp
index 9086c9acc43..bacdee4b370 100644
--- a/clang/test/SemaCXX/unknown-type-name.cpp
+++ b/clang/test/SemaCXX/unknown-type-name.cpp
@@ -72,9 +72,7 @@ void f(int, T::type x, char) { } // expected-error{{missing 'typename'}}
int *p;
-// FIXME: We should assume that 'undeclared' is a type, not a parameter name
-// here, and produce an 'unknown type name' diagnostic instead.
-int f1(undeclared, int); // expected-error{{requires a type specifier}}
+int f1(undeclared, int); // expected-error{{unknown type name 'undeclared'}}
int f2(undeclared, 0); // expected-error{{undeclared identifier}}
OpenPOWER on IntegriCloud