summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAaron Ballman <aaron@aaronballman.com>2015-04-27 22:31:12 +0000
committerAaron Ballman <aaron@aaronballman.com>2015-04-27 22:31:12 +0000
commitedc80847514bd598bf8567166561fb8c5928dc5d (patch)
treeb674a2a5aa91d2419942da3eba6a93b2b921276e
parentca5ad5fb6dc7d39cddb687adde1f9bef20b63bd8 (diff)
downloadbcm5719-llvm-edc80847514bd598bf8567166561fb8c5928dc5d.tar.gz
bcm5719-llvm-edc80847514bd598bf8567166561fb8c5928dc5d.zip
Check whether the operand to a noexcept expression is valid or not. Fixes PR15842.
llvm-svn: 235931
-rw-r--r--clang/lib/Sema/SemaExprCXX.cpp10
-rw-r--r--clang/test/SemaCXX/cxx0x-noexcept-expression.cpp19
2 files changed, 29 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index b050c933044..bb67939ad89 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -5791,6 +5791,16 @@ ExprResult Sema::BuildCXXMemberCallExpr(Expr *E, NamedDecl *FoundDecl,
ExprResult Sema::BuildCXXNoexceptExpr(SourceLocation KeyLoc, Expr *Operand,
SourceLocation RParen) {
+ // If the operand is an unresolved lookup expression, the expression is ill-
+ // formed per [over.over]p1, because overloaded function names cannot be used
+ // without arguments except in explicit contexts.
+ ExprResult R = CheckPlaceholderExpr(Operand);
+ if (R.isInvalid())
+ return R;
+
+ // The operand may have been modified when checking the placeholder type.
+ Operand = R.get();
+
if (ActiveTemplateInstantiations.empty() &&
Operand->HasSideEffects(Context, false)) {
// The expression operand for noexcept is in an unevaluated expression
diff --git a/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp b/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp
new file mode 100644
index 00000000000..ba51365d472
--- /dev/null
+++ b/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp
@@ -0,0 +1,19 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
+
+void f(); // expected-note {{possible target for call}}
+void f(int); // expected-note {{possible target for call}}
+
+void g() {
+ bool b = noexcept(f); // expected-error {{reference to overloaded function could not be resolved; did you mean to call it with no arguments?}}
+ bool b2 = noexcept(f(0));
+}
+
+struct S {
+ void g(); // expected-note {{possible target for call}}
+ void g(int); // expected-note {{possible target for call}}
+
+ void h() {
+ bool b = noexcept(this->g); // expected-error {{reference to non-static member function must be called; did you mean to call it with no arguments?}}
+ bool b2 = noexcept(this->g(0));
+ }
+};
OpenPOWER on IntegriCloud