summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTed Kremenek <kremenek@apple.com>2011-11-14 23:51:37 +0000
committerTed Kremenek <kremenek@apple.com>2011-11-14 23:51:37 +0000
commitec9b50d961a00ff603b49fbb71f56dbc0fa62b3a (patch)
tree6b7a91d27655b7e755272f1a6b3758555f4f4956
parent02faa354770577d1327a03d9ffd1f9dbc022a1f4 (diff)
downloadbcm5719-llvm-ec9b50d961a00ff603b49fbb71f56dbc0fa62b3a.tar.gz
bcm5719-llvm-ec9b50d961a00ff603b49fbb71f56dbc0fa62b3a.zip
Fix potential memory leak for clients of clang_getOverriddenCursors(). If the number of overriden cursors is 0, do not allocate an array of CXCursors. This fixes a memory leak in c-index-test, and clients who use this API in a similar way.
llvm-svn: 144595
-rw-r--r--clang/tools/libclang/CIndex.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/clang/tools/libclang/CIndex.cpp b/clang/tools/libclang/CIndex.cpp
index f9a873819a9..8f4b0471f88 100644
--- a/clang/tools/libclang/CIndex.cpp
+++ b/clang/tools/libclang/CIndex.cpp
@@ -5240,6 +5240,10 @@ void clang_getOverriddenCursors(CXCursor cursor,
SmallVector<CXCursor, 8> Overridden;
cxcursor::getOverriddenCursors(cursor, Overridden);
+ // Don't allocate memory if we have no overriden cursors.
+ if (Overridden.size() == 0)
+ return;
+
*num_overridden = Overridden.size();
*overridden = new CXCursor [Overridden.size()];
std::copy(Overridden.begin(), Overridden.end(), *overridden);
OpenPOWER on IntegriCloud