diff options
| author | Douglas Gregor <dgregor@apple.com> | 2010-09-17 22:41:34 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2010-09-17 22:41:34 +0000 |
| commit | ec06c124f1f58d358f14933f5ecabb6e2e669874 (patch) | |
| tree | dc82bb6c5ea6325b69ec3c20b8b378440f25321a | |
| parent | 7a6c37d3e7f6ed63e5bbe1c941744a156335fbc7 (diff) | |
| download | bcm5719-llvm-ec06c124f1f58d358f14933f5ecabb6e2e669874.tar.gz bcm5719-llvm-ec06c124f1f58d358f14933f5ecabb6e2e669874.zip | |
Improve recovery when the middle expression of a ternary operator is ill-formed
llvm-svn: 114231
| -rw-r--r-- | clang/lib/Parse/ParseExpr.cpp | 6 | ||||
| -rw-r--r-- | clang/test/Index/complete-recovery.m | 2 |
2 files changed, 6 insertions, 2 deletions
diff --git a/clang/lib/Parse/ParseExpr.cpp b/clang/lib/Parse/ParseExpr.cpp index c3c4b4144a4..ec2c5d6b955 100644 --- a/clang/lib/Parse/ParseExpr.cpp +++ b/clang/lib/Parse/ParseExpr.cpp @@ -291,8 +291,10 @@ Parser::ParseRHSOfBinaryExpression(ExprResult LHS, prec::Level MinPrec) { // In particular, the RHS of the '?' is 'expression', not // 'logical-OR-expression' as we might expect. TernaryMiddle = ParseExpression(); - if (TernaryMiddle.isInvalid()) - return move(TernaryMiddle); + if (TernaryMiddle.isInvalid()) { + LHS = ExprError(); + TernaryMiddle = 0; + } } else { // Special case handling of "X ? Y : Z" where Y is empty: // logical-OR-expression '?' ':' conditional-expression [GNU] diff --git a/clang/test/Index/complete-recovery.m b/clang/test/Index/complete-recovery.m index 66084cdcec1..5141a533aea 100644 --- a/clang/test/Index/complete-recovery.m +++ b/clang/test/Index/complete-recovery.m @@ -10,6 +10,7 @@ blarg * blah = wibble; A *a2; z = [a2 method:1]; + blah ? blech : [a2 method:1]; } @end @@ -27,3 +28,4 @@ // CHECK-CC2: NotImplemented:{TypedText sizeof}{LeftParen (}{Placeholder expression-or-type}{RightParen )} // RUN: c-index-test -code-completion-at=%s:12:11 -Xclang -code-completion-patterns %s | FileCheck -check-prefix=CHECK-CC3 %s // CHECK-CC3: ObjCInstanceMethodDecl:{ResultType void}{TypedText method:}{Placeholder (int)} (17) +// RUN: c-index-test -code-completion-at=%s:13:22 -Xclang -code-completion-patterns %s | FileCheck -check-prefix=CHECK-CC3 %s |
