summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Friedman <eli.friedman@gmail.com>2011-11-03 20:31:28 +0000
committerEli Friedman <eli.friedman@gmail.com>2011-11-03 20:31:28 +0000
commiteadd3e81a04ec492301333502f74f97e98215849 (patch)
treef3e18fa0ed81b0c9badb23d286e4acf8a2fb2d1f
parentf50f7b2c6553c871bb7e2c9b278beadf973a9135 (diff)
downloadbcm5719-llvm-eadd3e81a04ec492301333502f74f97e98215849.tar.gz
bcm5719-llvm-eadd3e81a04ec492301333502f74f97e98215849.zip
Fix the alignment on scalar parameter variables so that it matches what the AST thinks it should be. Per report on cfe-dev.
llvm-svn: 143645
-rw-r--r--clang/lib/CodeGen/CGDecl.cpp5
-rw-r--r--clang/test/CodeGen/align-param.c9
2 files changed, 13 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index a6147ea7658..384d92a9bf4 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -1442,7 +1442,10 @@ void CodeGenFunction::EmitParmDecl(const VarDecl &D, llvm::Value *Arg,
DeclPtr = Arg;
} else {
// Otherwise, create a temporary to hold the value.
- DeclPtr = CreateMemTemp(Ty, D.getName() + ".addr");
+ llvm::AllocaInst *Alloc = CreateTempAlloca(ConvertTypeForMem(Ty),
+ D.getName() + ".addr");
+ Alloc->setAlignment(getContext().getDeclAlign(&D).getQuantity());
+ DeclPtr = Alloc;
bool doStore = true;
diff --git a/clang/test/CodeGen/align-param.c b/clang/test/CodeGen/align-param.c
new file mode 100644
index 00000000000..15a8c2a79a3
--- /dev/null
+++ b/clang/test/CodeGen/align-param.c
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -emit-llvm -triple i386-apple-macosx10.7.2 < %s | FileCheck %s
+
+// The preferred alignment for a long long on x86-32 is 8; make sure the
+// alloca for x uses that alignment.
+int test (long long x) {
+ return (int)x;
+}
+// CHECK: define i32 @test
+// CHECK: alloca i64, align 8
OpenPOWER on IntegriCloud