summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2016-09-15 06:44:48 +0000
committerVedant Kumar <vsk@apple.com>2016-09-15 06:44:48 +0000
commitea1e97b94ccaa25cc71cb0900c3dfd3d00e18b43 (patch)
tree7f249db4faa4941a9d0bf6bb456bab744c535fa6
parent6582669aa9dd757c17110fd993b8acd8b320f0f0 (diff)
downloadbcm5719-llvm-ea1e97b94ccaa25cc71cb0900c3dfd3d00e18b43.tar.gz
bcm5719-llvm-ea1e97b94ccaa25cc71cb0900c3dfd3d00e18b43.zip
[llvm-cov] Don't create 'jump to ...' links in nested views
Doing so is pointless, since the whole view is usually visible in a small amount of space. llvm-svn: 281588
-rw-r--r--llvm/test/tools/llvm-cov/showTemplateInstantiations.cpp4
-rw-r--r--llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp2
2 files changed, 5 insertions, 1 deletions
diff --git a/llvm/test/tools/llvm-cov/showTemplateInstantiations.cpp b/llvm/test/tools/llvm-cov/showTemplateInstantiations.cpp
index 40ac9d3ad88..38ad0cfa8c9 100644
--- a/llvm/test/tools/llvm-cov/showTemplateInstantiations.cpp
+++ b/llvm/test/tools/llvm-cov/showTemplateInstantiations.cpp
@@ -83,3 +83,7 @@ int main() { // ALL: [[@LINE]]| 1|int main() {
// HTML-ALL: <td class='line-number'><a name='L[[@LINE-45]]'><pre>[[@LINE-45]]</pre></a></td><td class='uncovered-line'></td><td class='code'><pre>// after
// HTML-FILTER-NOT: <td class='line-number'><a name='L[[@LINE-46]]'><pre>[[@LINE-46]]</pre></a></td><td class='uncovered-line'></td><td class='code'><pre>// after
+
+// RUN: FileCheck -check-prefix=HTML-JUMP -input-file=%t.html.dir/coverage/tmp/showTemplateInstantiations.cpp.html %s
+// HTML-JUMP: <pre>Source (<a href='#L{{[0-9]+}}'>jump to first uncovered line</a>)</pre>
+// HTML-JUMP-NOT: <pre>Source (<a href='#L{{[0-9]+}}'>jump to first uncovered line</a>)</pre>
diff --git a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp
index 2fef1b4175d..0f176551550 100644
--- a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp
+++ b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp
@@ -601,7 +601,7 @@ void SourceCoverageViewHTML::renderTableHeader(raw_ostream &OS,
unsigned FirstUncoveredLineNo,
unsigned ViewDepth) {
std::string SourceLabel;
- if (FirstUncoveredLineNo == 0) {
+ if (FirstUncoveredLineNo == 0 || ViewDepth > 0) {
SourceLabel = tag("td", tag("pre", "Source"));
} else {
std::string LinkTarget = "#L" + utostr(uint64_t(FirstUncoveredLineNo));
OpenPOWER on IntegriCloud