summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Kramer <benny.kra@googlemail.com>2014-08-29 08:58:35 +0000
committerBenjamin Kramer <benny.kra@googlemail.com>2014-08-29 08:58:35 +0000
commite59cd6e6ffd304d5de84a316a07fd9d7e22eb7f6 (patch)
treefe715e4445c8647b4949e067f230b8eafde9a916
parenta651a62340ae1568aa33368219641cf3e6174ee0 (diff)
downloadbcm5719-llvm-e59cd6e6ffd304d5de84a316a07fd9d7e22eb7f6.tar.gz
bcm5719-llvm-e59cd6e6ffd304d5de84a316a07fd9d7e22eb7f6.zip
[clang-tidy] Don't suggest naming unnamed parameters on deleted/defaulted functions.
llvm-svn: 216718
-rw-r--r--clang-tools-extra/clang-tidy/google/NamedParameterCheck.cpp3
-rw-r--r--clang-tools-extra/test/clang-tidy/google-readability-function.cpp3
2 files changed, 5 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/google/NamedParameterCheck.cpp b/clang-tools-extra/clang-tidy/google/NamedParameterCheck.cpp
index ab901bc2821..db5bdbe41d1 100644
--- a/clang-tools-extra/clang-tidy/google/NamedParameterCheck.cpp
+++ b/clang-tools-extra/clang-tidy/google/NamedParameterCheck.cpp
@@ -40,7 +40,8 @@ void NamedParameterCheck::check(const MatchFinder::MatchResult &Result) {
// Ignore declarations without a definition if we're not dealing with an
// overriden method.
const FunctionDecl *Definition = nullptr;
- if (!Function->isDefined(Definition) &&
+ if ((!Function->isDefined(Definition) || Function->isDefaulted() ||
+ Function->isDeleted()) &&
(!isa<CXXMethodDecl>(Function) ||
cast<CXXMethodDecl>(Function)->size_overridden_methods() == 0))
return;
diff --git a/clang-tools-extra/test/clang-tidy/google-readability-function.cpp b/clang-tools-extra/test/clang-tidy/google-readability-function.cpp
index 701c5fc4288..75c743b6f5a 100644
--- a/clang-tools-extra/test/clang-tidy/google-readability-function.cpp
+++ b/clang-tools-extra/test/clang-tidy/google-readability-function.cpp
@@ -43,6 +43,9 @@ struct X {
// CHECK-FIXES: X operator++(int /*unused*/) {}
X operator--(int /*unused*/) {}
+ X(X&) = delete;
+ X &operator=(X&) = default;
+
const int &i;
};
OpenPOWER on IntegriCloud