diff options
| author | David Bolvansky <david.bolvansky@gmail.com> | 2019-09-24 20:10:57 +0000 |
|---|---|---|
| committer | David Bolvansky <david.bolvansky@gmail.com> | 2019-09-24 20:10:57 +0000 |
| commit | e52ed1e80cc3d6ef4913650962853d512cf2c6bf (patch) | |
| tree | 1335af3a4134f924b63f93e347f026da17b15c04 | |
| parent | 7de14dc3c60593569a93aba75e22f0085d2d3b04 (diff) | |
| download | bcm5719-llvm-e52ed1e80cc3d6ef4913650962853d512cf2c6bf.tar.gz bcm5719-llvm-e52ed1e80cc3d6ef4913650962853d512cf2c6bf.zip | |
[NFC] Strenghten preconditions for warning
llvm-svn: 372775
| -rw-r--r-- | clang/lib/Sema/SemaChecking.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 02c0d489ae0..28f4e06cd72 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -11321,7 +11321,8 @@ static void DiagnoseIntInBoolContext(Sema &S, Expr *E) { const auto *RHS = getIntegerLiteral(BO->getRHS()); if (LHS && LHS->getValue() == 0) S.Diag(ExprLoc, diag::warn_left_shift_always) << 0; - else if (RHS && RHS->getValue().isNonNegative() && + else if (!E->isValueDependent() && LHS && RHS && + RHS->getValue().isNonNegative() && E->EvaluateAsInt(Result, S.Context, Expr::SE_AllowSideEffects)) S.Diag(ExprLoc, diag::warn_left_shift_always) << (Result.Val.getInt() != 0); |
