diff options
| author | Craig Topper <craig.topper@intel.com> | 2017-12-05 04:47:12 +0000 |
|---|---|---|
| committer | Craig Topper <craig.topper@intel.com> | 2017-12-05 04:47:12 +0000 |
| commit | e1ba2450c2ec7954911fa7c7234c4b3f3be9f9ec (patch) | |
| tree | b0a9fcce9afe12b30ef37a29ec281cd0136f3da2 | |
| parent | 7700912976a5948d31a0e34fe9f8c1059afabcac (diff) | |
| download | bcm5719-llvm-e1ba2450c2ec7954911fa7c7234c4b3f3be9f9ec.tar.gz bcm5719-llvm-e1ba2450c2ec7954911fa7c7234c4b3f3be9f9ec.zip | |
[X86] Fix a crash if avx512bw and xop are both enabled when the IR contrains a v32i8 bitreverse.
llvm-svn: 319737
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 5 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/vector-bitreverse.ll | 3 |
2 files changed, 6 insertions, 2 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index eae3800f86b..8e440743814 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -23792,12 +23792,13 @@ static SDValue LowerBITREVERSE_XOP(SDValue Op, SelectionDAG &DAG) { static SDValue LowerBITREVERSE(SDValue Op, const X86Subtarget &Subtarget, SelectionDAG &DAG) { - if (Subtarget.hasXOP()) + MVT VT = Op.getSimpleValueType(); + + if (Subtarget.hasXOP() && !VT.is512BitVector()) return LowerBITREVERSE_XOP(Op, DAG); assert(Subtarget.hasSSSE3() && "SSSE3 required for BITREVERSE"); - MVT VT = Op.getSimpleValueType(); SDValue In = Op.getOperand(0); SDLoc DL(Op); diff --git a/llvm/test/CodeGen/X86/vector-bitreverse.ll b/llvm/test/CodeGen/X86/vector-bitreverse.ll index 0eb3a64311a..51b5219f302 100644 --- a/llvm/test/CodeGen/X86/vector-bitreverse.ll +++ b/llvm/test/CodeGen/X86/vector-bitreverse.ll @@ -8,6 +8,9 @@ ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+xop,+avx | FileCheck %s --check-prefix=ALL --check-prefix=XOP --check-prefix=XOPAVX1 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+xop,+avx2 | FileCheck %s --check-prefix=ALL --check-prefix=XOP --check-prefix=XOPAVX2 +; Make sure we don't crash with avx512bw and xop +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+xop,+avx512bw + define i8 @test_bitreverse_i8(i8 %a) nounwind { ; SSE-LABEL: test_bitreverse_i8: ; SSE: # %bb.0: |
