summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonas Devlieghere <jonas@devlieghere.com>2019-12-11 10:43:31 -0800
committerJonas Devlieghere <jonas@devlieghere.com>2019-12-11 10:46:07 -0800
commitdb76588964ee255da1f32b06565a2cd899a82947 (patch)
tree18a735a6b6ef64bccf8aa6047d83775fed359924
parentd1f0bdf2d2df9bdf11ee2ddfff3df50e53f2f042 (diff)
downloadbcm5719-llvm-db76588964ee255da1f32b06565a2cd899a82947.tar.gz
bcm5719-llvm-db76588964ee255da1f32b06565a2cd899a82947.zip
[StringRef] Test all default characters in unit test
The default characters for trim, ltrim and rtrim are " \t\n\v\f\r" but only spaces were tested. Test that the others are trimmed as well.
-rw-r--r--llvm/unittests/ADT/StringRefTest.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp
index c37ecf36b63..2e5159dde1c 100644
--- a/llvm/unittests/ADT/StringRefTest.cpp
+++ b/llvm/unittests/ADT/StringRefTest.cpp
@@ -324,16 +324,20 @@ TEST(StringRefTest, Trim) {
StringRef Str0("hello");
StringRef Str1(" hello ");
StringRef Str2(" hello ");
+ StringRef Str3("\t\n\v\f\r hello \t\n\v\f\r");
EXPECT_EQ(StringRef("hello"), Str0.rtrim());
EXPECT_EQ(StringRef(" hello"), Str1.rtrim());
EXPECT_EQ(StringRef(" hello"), Str2.rtrim());
+ EXPECT_EQ(StringRef("\t\n\v\f\r hello"), Str3.rtrim());
EXPECT_EQ(StringRef("hello"), Str0.ltrim());
EXPECT_EQ(StringRef("hello "), Str1.ltrim());
EXPECT_EQ(StringRef("hello "), Str2.ltrim());
+ EXPECT_EQ(StringRef("hello \t\n\v\f\r"), Str3.ltrim());
EXPECT_EQ(StringRef("hello"), Str0.trim());
EXPECT_EQ(StringRef("hello"), Str1.trim());
EXPECT_EQ(StringRef("hello"), Str2.trim());
+ EXPECT_EQ(StringRef("hello"), Str3.trim());
EXPECT_EQ(StringRef("ello"), Str0.trim("hhhhhhhhhhh"));
OpenPOWER on IntegriCloud