summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRainer Orth <ro@gcc.gnu.org>2019-06-20 21:33:09 +0000
committerRainer Orth <ro@gcc.gnu.org>2019-06-20 21:33:09 +0000
commitd5f16d6cfccc4b0b13b6c01d16c673886d53e695 (patch)
tree6dd6dec0ab8c113f52d6713c12c7ddc5965baec0
parent6fde832b82daa0ddc19b88b281528b13dbf3958d (diff)
downloadbcm5719-llvm-d5f16d6cfccc4b0b13b6c01d16c673886d53e695.tar.gz
bcm5719-llvm-d5f16d6cfccc4b0b13b6c01d16c673886d53e695.zip
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Clang :: Driver/cl-response-file.c currently FAILs on Solaris: Command Output (stderr): -- /vol/llvm/src/clang/dist/test/Driver/cl-response-file.c:10:11: error: CHECK: expected string not found in input // CHECK: "-I" "{{.*}}\\Inputs\\cl-response-file\\" "-D" "FOO=2" ^ Looking at the generated response file reveals that this is no surprise: /I/vol/llvm/src/clang/dist/test/Driver\Inputs with no newline at the end. The echo command used to create it boils down to echo 'a\cb' However, one cannot expect \c to be emitted literally: e.g. bash's builtin echo has \c suppress further output I've tried various combinations of builtin echo, /usr/bin/echo, GNU echo if different, the same for printf, and the backslash unescaped and quoted (a\cb and a\\cb). The only combination that worked reliably on Solaris, Linux, and macOS was printf 'a\\cb' so this is what this patch uses. Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu. Differential Revision: https://reviews.llvm.org/D63600 llvm-svn: 363985
-rw-r--r--clang/test/Driver/cl-response-file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/test/Driver/cl-response-file.c b/clang/test/Driver/cl-response-file.c
index 51ee00bff4e..9186c43050d 100644
--- a/clang/test/Driver/cl-response-file.c
+++ b/clang/test/Driver/cl-response-file.c
@@ -4,7 +4,7 @@
-// RUN: echo '/I%S\Inputs\cl-response-file\ /DFOO=2' > %t.rsp
+// RUN: printf '/I%S\Inputs\\cl-response-file\ /DFOO=2' > %t.rsp
// RUN: %clang_cl /c -### @%t.rsp -- %s 2>&1 | FileCheck %s
// CHECK: "-I" "{{.*}}\\Inputs\\cl-response-file\\" "-D" "FOO=2"
OpenPOWER on IntegriCloud