diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2019-02-05 23:48:13 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2019-02-05 23:48:13 +0000 |
| commit | d3391bdd916ba7bd4483ca3632bd68a9d09f7fa6 (patch) | |
| tree | ef7f51c53d4a5eb97a8d1977d74a3ecaeb3d5f9b | |
| parent | 052f7ff96a85e109992bf7923583e5ca1d305774 (diff) | |
| download | bcm5719-llvm-d3391bdd916ba7bd4483ca3632bd68a9d09f7fa6.tar.gz bcm5719-llvm-d3391bdd916ba7bd4483ca3632bd68a9d09f7fa6.zip | |
gn build: Fix clang-tidy build
Not depending on //clang/lib/StaticAnalyzer/Core and
//clang/lib/StaticAnalyzer/Frontend causes a linker error even if
ClangSACheckers are not supported.
Undefined symbols for architecture x86_64:
"clang::ento::CreateAnalysisConsumer(clang::CompilerInstance&)", referenced from:
clang::tidy::ClangTidyASTConsumerFactory::CreateASTConsumer(
clang::CompilerInstance&, llvm::StringRef)
in libclangTidy.a(libclangTidy.ClangTidy.o)
Patch from Mirko Bonadei <mbonadei@webrtc.org>!
Differential Revision: https://reviews.llvm.org/D57777
llvm-svn: 353244
| -rw-r--r-- | llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn b/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn index 3356f0f6cf2..4d233e987fe 100644 --- a/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn +++ b/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn @@ -22,14 +22,12 @@ static_library("clang-tidy") { # ClangSACheckers ] - # TODO(mbonadei): Add support for Clang Static Analyzer checkers. - # Without this, "clang-analyzer-" will not work. - # if (clang_enable_static_analyzer) { - # deps += [ - # "//clang/lib/StaticAnalyzer/Core", - # "//clang/lib/StaticAnalyzer/Frontend", - # ] - # } + if (clang_enable_static_analyzer) { + deps += [ + "//clang/lib/StaticAnalyzer/Core", + "//clang/lib/StaticAnalyzer/Frontend", + ] + } sources = [ "ClangTidy.cpp", |
