diff options
| author | Tim Northover <tnorthover@apple.com> | 2017-08-08 23:17:51 +0000 |
|---|---|---|
| committer | Tim Northover <tnorthover@apple.com> | 2017-08-08 23:17:51 +0000 |
| commit | d1fafc8b0569b1cef000e1063657e2752f41ecb4 (patch) | |
| tree | dcbd9648de59e25bccb8b201d6ed11f220501dc6 | |
| parent | 8dd90fb54b2b0c1fd0209ecbbd78c242863e2aa8 (diff) | |
| download | bcm5719-llvm-d1fafc8b0569b1cef000e1063657e2752f41ecb4.tar.gz bcm5719-llvm-d1fafc8b0569b1cef000e1063657e2752f41ecb4.zip | |
Revert "Lexer: always allow imaginary constants in GNU mode."
This reverts r310423. It was committed by mistake, I intended to commit the
improved diagnostics for implicit conversions instead.
llvm-svn: 310426
| -rw-r--r-- | clang/lib/Lex/LiteralSupport.cpp | 2 | ||||
| -rw-r--r-- | clang/test/Lexer/imaginary-constants.cpp | 25 | ||||
| -rw-r--r-- | clang/test/SemaCXX/constexpr-printing.cpp | 2 | ||||
| -rw-r--r-- | clang/unittests/AST/DeclTest.cpp | 2 |
4 files changed, 3 insertions, 28 deletions
diff --git a/clang/lib/Lex/LiteralSupport.cpp b/clang/lib/Lex/LiteralSupport.cpp index 52b259edce8..a598a467816 100644 --- a/clang/lib/Lex/LiteralSupport.cpp +++ b/clang/lib/Lex/LiteralSupport.cpp @@ -659,7 +659,7 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, } } // "i", "if", and "il" are user-defined suffixes in C++1y. - if (*s == 'i' && !PP.getLangOpts().GNUMode) + if (*s == 'i' && PP.getLangOpts().CPlusPlus14) break; // fall through. case 'j': diff --git a/clang/test/Lexer/imaginary-constants.cpp b/clang/test/Lexer/imaginary-constants.cpp deleted file mode 100644 index 3a176be54a1..00000000000 --- a/clang/test/Lexer/imaginary-constants.cpp +++ /dev/null @@ -1,25 +0,0 @@ -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=gnu++98 -DHAVE_IMAGINARY=1 -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=gnu++11 -DHAVE_IMAGINARY=1 -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=gnu++14 -DHAVE_IMAGINARY=1 -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++98 -DHAVE_IMAGINARY=0 -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -DHAVE_IMAGINARY=0 -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++14 -DHAVE_IMAGINARY=0 -DCXX14=1 - -// Imaginary constants are a GNU extension that became problematic when C++14 -// defined its own versions. Until then they're supported even in -// standards-compliant mode. -#if HAVE_IMAGINARY -// expected-no-diagnostics -#elif CXX14 -// expected-error@+9 {{no matching literal operator for call to 'operator""i' with argument of type 'unsigned long long' or 'const char *', and no matching literal operator template}} -// expected-error@+9 {{no matching literal operator for call to 'operator""il' with argument of type 'unsigned long long' or 'const char *', and no matching literal operator template}} -// expected-error@+9 {{invalid suffix 'ill' on integer constant}} -#else -// expected-error@+5 {{invalid suffix 'i' on integer constant}} -// expected-error@+5 {{invalid suffix 'il' on integer constant}} -// expected-error@+7 {{invalid suffix 'ill' on integer constant}} -#endif - -_Complex int val1 = 2i; -_Complex long val2 = 2il; -_Complex long long val3 = 2ill; diff --git a/clang/test/SemaCXX/constexpr-printing.cpp b/clang/test/SemaCXX/constexpr-printing.cpp index 3112fdeb355..7f6a9c6a82f 100644 --- a/clang/test/SemaCXX/constexpr-printing.cpp +++ b/clang/test/SemaCXX/constexpr-printing.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 %s -std=gnu++11 -fsyntax-only -verify -triple x86_64-linux-gnu +// RUN: %clang_cc1 %s -std=c++11 -fsyntax-only -verify -triple x86_64-linux-gnu struct S; constexpr int extract(const S &s); diff --git a/clang/unittests/AST/DeclTest.cpp b/clang/unittests/AST/DeclTest.cpp index f06f21a55dc..87aeef47c61 100644 --- a/clang/unittests/AST/DeclTest.cpp +++ b/clang/unittests/AST/DeclTest.cpp @@ -26,7 +26,7 @@ TEST(Decl, CleansUpAPValues) { // This is a regression test for a memory leak in APValues for structs that // allocate memory. This test only fails if run under valgrind with full leak // checking enabled. - std::vector<std::string> Args(1, "-std=gnu++11"); + std::vector<std::string> Args(1, "-std=c++11"); Args.push_back("-fno-ms-extensions"); ASSERT_TRUE(runToolOnCodeWithArgs( Factory->create(), |

