summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2011-03-28 16:23:34 +0000
committerFariborz Jahanian <fjahanian@apple.com>2011-03-28 16:23:34 +0000
commitd0d31bf2633e2b3855445dcccdd49a6b6875c7fc (patch)
treeb1229b97207f334c156aab96619b1797e9803ddb
parent87c19f61d4be84716158e0e56ca7b3fe7ddd3329 (diff)
downloadbcm5719-llvm-d0d31bf2633e2b3855445dcccdd49a6b6875c7fc.tar.gz
bcm5719-llvm-d0d31bf2633e2b3855445dcccdd49a6b6875c7fc.zip
Also 'self' in blocks need be handled specially.
// rdar://9181463 llvm-svn: 128410
-rw-r--r--clang/lib/Sema/SemaExprObjC.cpp5
-rw-r--r--clang/test/SemaObjC/self-in-function.m5
2 files changed, 8 insertions, 2 deletions
diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp
index 22a1b19921b..cf38225de0c 100644
--- a/clang/lib/Sema/SemaExprObjC.cpp
+++ b/clang/lib/Sema/SemaExprObjC.cpp
@@ -325,7 +325,10 @@ bool Sema::CheckMessageArgumentTypes(Expr **Args, unsigned NumArgs,
bool Sema::isSelfExpr(Expr *RExpr) {
// 'self' is objc 'self' in an objc method only.
- if (!isa<ObjCMethodDecl>(CurContext))
+ DeclContext *DC = CurContext;
+ while (isa<BlockDecl>(DC))
+ DC = DC->getParent();
+ if (DC && !isa<ObjCMethodDecl>(DC))
return false;
if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(RExpr))
if (ICE->getCastKind() == CK_LValueToRValue)
diff --git a/clang/test/SemaObjC/self-in-function.m b/clang/test/SemaObjC/self-in-function.m
index 901cc31e47a..9027a947a03 100644
--- a/clang/test/SemaObjC/self-in-function.m
+++ b/clang/test/SemaObjC/self-in-function.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsyntax-only -fblocks -verify %s
// rdar://9181463
typedef struct objc_class *Class;
@@ -14,6 +14,9 @@ typedef struct objc_object {
void foo(Class self) {
[self alloc];
+ (^() {
+ [self alloc];
+ })();
}
void bar(Class self) {
OpenPOWER on IntegriCloud