diff options
| author | Ted Kremenek <kremenek@apple.com> | 2014-01-09 20:19:45 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2014-01-09 20:19:45 +0000 |
| commit | ce0e3f8a0920b72703b13a032a1809fae65423ee (patch) | |
| tree | 70d1e79a6e2a667ac37b29019b77bda4b5483e3f | |
| parent | 7c1fcf8b2cabd683beac967cbedc187d19c23487 (diff) | |
| download | bcm5719-llvm-ce0e3f8a0920b72703b13a032a1809fae65423ee.tar.gz bcm5719-llvm-ce0e3f8a0920b72703b13a032a1809fae65423ee.zip | |
Have attribute 'objc_precise_lifetime' suppress -Wunused.
Fixes <rdar://problem/15596883>
In ARC, __attribute__((objc_precise_lifetime)) guarantees that the
object stored in it will survive to the end of the variable's formal
lifetime. It is therefore useful even if it completely unused.
llvm-svn: 198888
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 3 | ||||
| -rw-r--r-- | clang/test/SemaObjC/unused.m | 9 |
2 files changed, 11 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index fb041ed98c8..78ead1ee92b 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -1268,7 +1268,8 @@ static bool ShouldDiagnoseUnusedDecl(const NamedDecl *D) { if (D->isInvalidDecl()) return false; - if (D->isReferenced() || D->isUsed() || D->hasAttr<UnusedAttr>()) + if (D->isReferenced() || D->isUsed() || D->hasAttr<UnusedAttr>() || + D->hasAttr<ObjCPreciseLifetimeAttr>()) return false; if (isa<LabelDecl>(D)) diff --git a/clang/test/SemaObjC/unused.m b/clang/test/SemaObjC/unused.m index 3fd1cf04673..16a38995ffd 100644 --- a/clang/test/SemaObjC/unused.m +++ b/clang/test/SemaObjC/unused.m @@ -72,3 +72,12 @@ static NSString *x = @"hi"; // expected-warning {{unused variable 'x'}} - (void) b {} - (void) a { [self b]; } @end + +// Test that objc_precise_lifetime suppresses +// unused variable warnings. +extern void rdar15596883_foo(void); +void rdar15596883(id x) { + __attribute__((objc_precise_lifetime)) id y = x; // no-warning + rdar15596883_foo(); +} + |
