diff options
| author | Alp Toker <alp@nuanti.com> | 2013-11-22 08:27:46 +0000 |
|---|---|---|
| committer | Alp Toker <alp@nuanti.com> | 2013-11-22 08:27:46 +0000 |
| commit | c8d4f0fa1d279de76053747ba8af6c64db94203e (patch) | |
| tree | ca82cc6548f5497a7af97459f739875f0812ed44 | |
| parent | b75d80fdf08bd0a7bf119d8f35a8060662478591 (diff) | |
| download | bcm5719-llvm-c8d4f0fa1d279de76053747ba8af6c64db94203e.tar.gz bcm5719-llvm-c8d4f0fa1d279de76053747ba8af6c64db94203e.zip | |
Tidy up the no-external-assembler diag
Diags aren't usually in the first person, and 'windows' isn't the correct
product spelling to use in prose. Sidestep issues completely by making this
error message platform-neutral.
llvm-svn: 195422
| -rw-r--r-- | clang/include/clang/Basic/DiagnosticDriverKinds.td | 4 | ||||
| -rw-r--r-- | clang/lib/Driver/WindowsToolChain.cpp | 2 | ||||
| -rw-r--r-- | clang/test/Driver/no-integrated-as-win.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td b/clang/include/clang/Basic/DiagnosticDriverKinds.td index 76d8c4aa7d6..b48980778c4 100644 --- a/clang/include/clang/Basic/DiagnosticDriverKinds.td +++ b/clang/include/clang/Basic/DiagnosticDriverKinds.td @@ -35,8 +35,8 @@ def err_drv_output_argument_with_multiple_files : Error< "cannot specify -o when generating multiple output files">; def err_drv_out_file_argument_with_multiple_sources : Error< "cannot specify '%0%1' when compiling multiple source files">; -def err_no_external_windows_assembler : Error< - "there is no external assembler we can use on windows">; +def err_no_external_assembler : Error< + "there is no external assembler that can be used on this platform">; def err_drv_unable_to_remove_file : Error< "unable to remove file: %0">; def err_drv_command_failure : Error< diff --git a/clang/lib/Driver/WindowsToolChain.cpp b/clang/lib/Driver/WindowsToolChain.cpp index db36f1eba71..2b6320ac12e 100644 --- a/clang/lib/Driver/WindowsToolChain.cpp +++ b/clang/lib/Driver/WindowsToolChain.cpp @@ -45,7 +45,7 @@ Tool *Windows::buildLinker() const { Tool *Windows::buildAssembler() const { if (getTriple().getEnvironment() == llvm::Triple::MachO) return new tools::darwin::Assemble(*this); - getDriver().Diag(clang::diag::err_no_external_windows_assembler); + getDriver().Diag(clang::diag::err_no_external_assembler); return NULL; } diff --git a/clang/test/Driver/no-integrated-as-win.c b/clang/test/Driver/no-integrated-as-win.c index 1ab2480c5d3..8f590a09016 100644 --- a/clang/test/Driver/no-integrated-as-win.c +++ b/clang/test/Driver/no-integrated-as-win.c @@ -1,5 +1,5 @@ // RUN: %clang -target x86_64-pc-win32 -### -no-integrated-as %s -c 2>&1 | FileCheck %s -// CHECK: there is no external assembler we can use on windows +// CHECK: there is no external assembler that can be used on this platform // But there is for mingw. The source file should only be mentioned once for // the compile step. |
