summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Liew <dan@su-root.co.uk>2016-01-09 21:42:57 +0000
committerDan Liew <dan@su-root.co.uk>2016-01-09 21:42:57 +0000
commitc754ace22f2df9501147b59b999fa5ad6e1a4427 (patch)
tree7a3fd73ba782ab5eb8e7101fbf77e086ac224460
parente1f72a6727f39f730601f7cb3537ac4f9065609b (diff)
downloadbcm5719-llvm-c754ace22f2df9501147b59b999fa5ad6e1a4427.tar.gz
bcm5719-llvm-c754ace22f2df9501147b59b999fa5ad6e1a4427.zip
Revert "Teach the CMake build system to run lit's test suite. These can be run"
This reverts r257221. This caused several build bot failures * It looks like some of the tests don't work correctly under Windows * It looks like the lit per test timeout tests fail So I'm reverting for now. Once the above failures are fixed running lit's tests can be enabled again. llvm-svn: 257268
-rw-r--r--llvm/CMakeLists.txt1
-rw-r--r--llvm/utils/lit/CMakeLists.txt26
-rw-r--r--llvm/utils/lit/tests/lit.cfg18
-rw-r--r--llvm/utils/lit/tests/lit.site.cfg.in8
4 files changed, 2 insertions, 51 deletions
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index bfd454323dc..3d2093fde63 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -697,7 +697,6 @@ if( LLVM_INCLUDE_TESTS )
EXCLUDE_FROM_ALL
NO_INSTALL)
endif()
- add_subdirectory(utils/lit)
add_subdirectory(test)
add_subdirectory(unittests)
if (MSVC)
diff --git a/llvm/utils/lit/CMakeLists.txt b/llvm/utils/lit/CMakeLists.txt
deleted file mode 100644
index 79862a7cbf9..00000000000
--- a/llvm/utils/lit/CMakeLists.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-# The configured file is not placed in the correct location
-# until the tests are run as we need to copy it into
-# a copy of the tests folder
-configure_file("tests/lit.site.cfg.in" "lit.site.cfg" @ONLY)
-
-# Lit's test suite creates output files next to the sources which makes the
-# source tree dirty. This is undesirable because we do out of source builds.
-# To work around this the tests and the configuration file are copied into the
-# build directory just before running them. The tests are not copied over at
-# configure time (i.e. ``file(COPY ...)``) because this could lead to stale
-# tests being run.
-add_custom_target(prepare-check-lit
- COMMAND ${CMAKE_COMMAND} -E copy_directory "${CMAKE_CURRENT_SOURCE_DIR}/tests" "${CMAKE_CURRENT_BINARY_DIR}/tests"
- COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg" "${CMAKE_CURRENT_BINARY_DIR}/tests"
- COMMENT "Preparing lit tests"
-)
-
-# Add rules for lit's own test suite
-add_lit_testsuite(check-lit "Running lit's tests"
- ${CMAKE_CURRENT_BINARY_DIR}
- DEPENDS "FileCheck" "not" "prepare-check-lit"
-)
-
-# For IDEs
-set_target_properties(check-lit PROPERTIES FOLDER "Tests")
-set_target_properties(prepare-check-lit PROPERTIES FOLDER "Tests")
diff --git a/llvm/utils/lit/tests/lit.cfg b/llvm/utils/lit/tests/lit.cfg
index 3ed5bc95129..4b38241d5a7 100644
--- a/llvm/utils/lit/tests/lit.cfg
+++ b/llvm/utils/lit/tests/lit.cfg
@@ -26,20 +26,12 @@ config.test_exec_root = config.test_source_root
config.target_triple = '(unused)'
src_root = os.path.join(config.test_source_root, '..')
-llvm_src_root = getattr(config, 'llvm_src_root', None)
-if llvm_src_root != None:
- # ``src_root`` may be in LLVM's binary build directory which does not contain
- # ``lit.py``, so use ``llvm_src_root`` instead.
- lit_path = os.path.join(llvm_src_root, 'utils', 'lit')
-else:
- lit_path = src_root
-
-config.environment['PYTHONPATH'] = lit_path # Required because some tests import the lit module
+config.environment['PYTHONPATH'] = src_root
config.substitutions.append(('%{src_root}', src_root))
config.substitutions.append(('%{inputs}', os.path.join(
src_root, 'tests', 'Inputs')))
config.substitutions.append(('%{lit}', "%%{python} %s" % (
- os.path.join(lit_path, 'lit.py'),)))
+ os.path.join(src_root, 'lit.py'),)))
config.substitutions.append(('%{python}', sys.executable))
# Enable coverage.py reporting, assuming the coverage module has been installed
@@ -60,9 +52,3 @@ try:
except ImportError:
lit_config.warning('Could not import psutil. Some tests will be skipped and'
' the --timeout command line argument will not work.')
-
-# Add llvm tools directory if this config is being loaded indirectly
-llvm_tools_dir = getattr(config, 'llvm_tools_dir', None)
-if llvm_tools_dir != None:
- path = os.path.pathsep.join((llvm_tools_dir, config.environment['PATH']))
- config.environment['PATH'] = path
diff --git a/llvm/utils/lit/tests/lit.site.cfg.in b/llvm/utils/lit/tests/lit.site.cfg.in
deleted file mode 100644
index bdc1f58575e..00000000000
--- a/llvm/utils/lit/tests/lit.site.cfg.in
+++ /dev/null
@@ -1,8 +0,0 @@
-## Autogenerated by LLVM/Clang configuration.
-# Do not edit!
-config.llvm_src_root = "@LLVM_SOURCE_DIR@"
-config.llvm_obj_root = "@LLVM_BINARY_DIR@"
-config.llvm_tools_dir = "@LLVM_TOOLS_BINARY_DIR@"
-
-# Let the main config do the real work.
-lit_config.load_config(config, "@LLVM_BINARY_DIR@/utils/lit/tests/lit.cfg")
OpenPOWER on IntegriCloud