diff options
author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2014-08-21 23:36:08 +0000 |
---|---|---|
committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2014-08-21 23:36:08 +0000 |
commit | c667974b6528a43bbcd6e798386ed97c8a710b42 (patch) | |
tree | 8a33d6bed3587974605d368e697effff94d1d2cb | |
parent | fb700b58cc0d69eb748b2f94afbd6f30c3ffd7ff (diff) | |
download | bcm5719-llvm-c667974b6528a43bbcd6e798386ed97c8a710b42.tar.gz bcm5719-llvm-c667974b6528a43bbcd6e798386ed97c8a710b42.zip |
Revert "X86: Align the stack on word boundaries in LowerFormalArguments()"
This (mostly) reverts commit r216119.
Somewhere during the review Reid committed r214980 which fixed this
another way, and I neglected to check that the testcase still failed
before committing.
I've left test/CodeGen/X86/aligned-variadic.ll around in case it adds
extra coverage.
llvm-svn: 216246
-rw-r--r-- | llvm/include/llvm/CodeGen/CallingConvLower.h | 9 | ||||
-rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 1 |
2 files changed, 2 insertions, 8 deletions
diff --git a/llvm/include/llvm/CodeGen/CallingConvLower.h b/llvm/include/llvm/CodeGen/CallingConvLower.h index ffedd2e1410..3446486f873 100644 --- a/llvm/include/llvm/CodeGen/CallingConvLower.h +++ b/llvm/include/llvm/CodeGen/CallingConvLower.h @@ -371,16 +371,11 @@ public: return Reg; } - /// AlignStack - Align the top of the stakc to the specified alignment. - void AlignStack(unsigned Align) { - assert(Align && ((Align - 1) & Align) == 0); // Align is power of 2. - StackOffset = ((StackOffset + Align - 1) & ~(Align - 1)); - } - /// AllocateStack - Allocate a chunk of stack space with the specified size /// and alignment. unsigned AllocateStack(unsigned Size, unsigned Align) { - AlignStack(Align); + assert(Align && ((Align - 1) & Align) == 0); // Align is power of 2. + StackOffset = ((StackOffset + Align - 1) & ~(Align - 1)); unsigned Result = StackOffset; StackOffset += Size; MF.getFrameInfo()->ensureMaxAlignment(Align); diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 00d1e5cd270..afcabdcda7e 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -2298,7 +2298,6 @@ X86TargetLowering::LowerFormalArguments(SDValue Chain, CCInfo.AllocateStack(32, 8); CCInfo.AnalyzeFormalArguments(Ins, CC_X86); - CCInfo.AlignStack(Is64Bit ? 8 : 4); unsigned LastVal = ~0U; SDValue ArgValue; |