diff options
| author | Petr Hosek <phosek@chromium.org> | 2019-06-23 23:12:10 +0000 |
|---|---|---|
| committer | Petr Hosek <phosek@chromium.org> | 2019-06-23 23:12:10 +0000 |
| commit | c6094f0495bfb874e908b4ef3ff8a6adde92be34 (patch) | |
| tree | 3265034270808a0ec69dbc40bb00227481f32bdb | |
| parent | fb2bd4a9398b35ee4f732ea0847d9c1226fc4cf3 (diff) | |
| download | bcm5719-llvm-c6094f0495bfb874e908b4ef3ff8a6adde92be34.tar.gz bcm5719-llvm-c6094f0495bfb874e908b4ef3ff8a6adde92be34.zip | |
[GN] Generation failure caused by trailing space in file name
When I executed gn.py gen out/gn I got the following error:
ERROR at //compiler-rt/lib/builtins/BUILD.gn:162:7: Only source, header, and object files belong in the sources of a static_library. //compiler-rt/lib/builtins/emutls.c is not one of the valid types.
"emutls.c ",
^----------
See //compiler-rt/lib/BUILD.gn:3:5: which caused the file to be included.
"//compiler-rt/lib/builtins",
^---------------------------
It turns out to be that the latest gn doesn't accept ill-format file name. And the emutls.c above has a trailing space.
Remove the trailing space should work.
Patch By: myhsu
Differential Revision: https://reviews.llvm.org/D63449
llvm-svn: 364162
| -rw-r--r-- | llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn b/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn index 2841fcac3df..53d638619a4 100644 --- a/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn +++ b/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn @@ -159,7 +159,7 @@ static_library("builtins") { if (target_os != "fuchsia") { sources += [ - "emutls.c ", + "emutls.c", "enable_execute_stack.c", "eprintf.c", ] |
