diff options
author | Chris Lattner <sabre@nondot.org> | 2007-11-16 06:04:17 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2007-11-16 06:04:17 +0000 |
commit | c53b18362a88f895cb7ac13c962f8db880f9844e (patch) | |
tree | 9bb061de3c873950e69f1f3fd06cf5974f136815 | |
parent | 1b3f58a816fea70921ac4f48d7d6ea36f11e95f6 (diff) | |
download | bcm5719-llvm-c53b18362a88f895cb7ac13c962f8db880f9844e.tar.gz bcm5719-llvm-c53b18362a88f895cb7ac13c962f8db880f9844e.zip |
Fix PR1800 by correcting mistaken logic.
llvm-svn: 44188
-rw-r--r-- | llvm/lib/Transforms/Scalar/InstructionCombining.cpp | 3 | ||||
-rw-r--r-- | llvm/test/Transforms/InstCombine/2007-11-15-CompareMiscomp.ll | 10 |
2 files changed, 11 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp index efcd8e32972..e8cd86778ae 100644 --- a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp @@ -3577,8 +3577,7 @@ Instruction *InstCombiner::visitAnd(BinaryOperator &I) { case ICmpInst::ICMP_SGT: switch (RHSCC) { default: assert(0 && "Unknown integer condition code!"); - case ICmpInst::ICMP_EQ: // (X s> 13 & X == 15) -> X s> 13 - return ReplaceInstUsesWith(I, LHS); + case ICmpInst::ICMP_EQ: // (X s> 13 & X == 15) -> X == 15 case ICmpInst::ICMP_SGT: // (X s> 13 & X s> 15) -> X s> 15 return ReplaceInstUsesWith(I, RHS); case ICmpInst::ICMP_UGT: // (X s> 13 & X u> 15) -> no change diff --git a/llvm/test/Transforms/InstCombine/2007-11-15-CompareMiscomp.ll b/llvm/test/Transforms/InstCombine/2007-11-15-CompareMiscomp.ll new file mode 100644 index 00000000000..d7ac2113728 --- /dev/null +++ b/llvm/test/Transforms/InstCombine/2007-11-15-CompareMiscomp.ll @@ -0,0 +1,10 @@ +; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep {icmp eq i32 %In, 1} +; PR1800 + +define i1 @test(i32 %In) { + %c1 = icmp sgt i32 %In, -1 + %c2 = icmp eq i32 %In, 1 + %V = and i1 %c1, %c2 + ret i1 %V +} + |