diff options
| author | Filipe Cabecinhas <me@filcab.net> | 2015-03-20 23:51:15 +0000 |
|---|---|---|
| committer | Filipe Cabecinhas <me@filcab.net> | 2015-03-20 23:51:15 +0000 |
| commit | c473255110f591dc9fe309e1ea134469a95c7e16 (patch) | |
| tree | b183d0bcd98e21b4b080a73ecbf06a086c11e5b3 | |
| parent | 37d5add8a33d4b0868ace2e057a28c0e6dce3704 (diff) | |
| download | bcm5719-llvm-c473255110f591dc9fe309e1ea134469a95c7e16.tar.gz bcm5719-llvm-c473255110f591dc9fe309e1ea134469a95c7e16.zip | |
Only add -fno-rtti if KernelOrKext or in C++ mode.
llvm-svn: 232869
| -rw-r--r-- | clang/lib/Driver/Tools.cpp | 5 | ||||
| -rw-r--r-- | clang/test/Driver/rtti-options.cpp | 9 |
2 files changed, 9 insertions, 5 deletions
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp index 94c71aca01c..0f44ce74b3b 100644 --- a/clang/lib/Driver/Tools.cpp +++ b/clang/lib/Driver/Tools.cpp @@ -4050,8 +4050,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, ToolChain::RTTIMode RTTIMode = getToolChain().getRTTIMode(); - if (RTTIMode == ToolChain::RM_DisabledExplicitly || - RTTIMode == ToolChain::RM_DisabledImplicitly) + if (KernelOrKext || (types::isCXX(InputType) && + (RTTIMode == ToolChain::RM_DisabledExplicitly || + RTTIMode == ToolChain::RM_DisabledImplicitly))) CmdArgs.push_back("-fno-rtti"); // -fshort-enums=0 is default for all architectures except Hexagon. diff --git a/clang/test/Driver/rtti-options.cpp b/clang/test/Driver/rtti-options.cpp index 087ee216236..46072ca6ea7 100644 --- a/clang/test/Driver/rtti-options.cpp +++ b/clang/test/Driver/rtti-options.cpp @@ -3,10 +3,12 @@ // No warnings/errors should be emitted for unknown, except if combining // the vptr sanitizer with -fno-rtti -// Special case: -fcxx-exceptions in C code should warn about unused arguments -// RUN: %clang -x c -### -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED %s -// CHECK-UNUSED: warning: argument unused during compilation: '-fcxx-exceptions' +// Special cases: -fcxx-exceptions in C code should warn about unused arguments +// We should also not have any rtti-related arguments +// RUN: %clang -x c -### -target x86_64-scei-ps4 -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI -check-prefix=CHECK-NO-RTTI %s +// RUN: %clang -x c -### -target x86_64-unknown-unknown -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI -check-prefix=CHECK-NO-RTTI %s +// Make sure we keep the last -frtti/-fno-rtti argument // RUN: %clang -### -c -fno-rtti -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI %s // RUN: %clang -### -c -frtti -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-NO-RTTI %s @@ -48,6 +50,7 @@ // RUN: %clang -### -c -target x86_64-unknown-unknown -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-NO-RTTI %s // RUN: %clang -### -c -target x86_64-unknown-unknown %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI %s +// CHECK-UNUSED: warning: argument unused during compilation: '-fcxx-exceptions' // CHECK-SAN-WARN: implicitly disabling vptr sanitizer because rtti wasn't enabled // CHECK-SAN-ERROR: invalid argument '-fsanitize=vptr' not allowed with '-fno-rtti' // CHECK-EXC-WARN: implicitly enabling rtti for exception handling |
