diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2016-10-19 15:59:28 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2016-10-19 15:59:28 +0000 |
| commit | c2e97249099db15523734c679bed0afafac04846 (patch) | |
| tree | efc86c65fd150ff346cb3073ff7def3b93b55b8a | |
| parent | e6999295076e1bf7c89bcd962db998cf410f677e (diff) | |
| download | bcm5719-llvm-c2e97249099db15523734c679bed0afafac04846.tar.gz bcm5719-llvm-c2e97249099db15523734c679bed0afafac04846.zip | |
[DAGCombiner] Add general constant vector support to (shl (mul x, c1), c2) -> (mul x, c1 << c2)
We already supported scalar constant / splatted constant vector - now accepts any (non opaque) constant scalar / vector
llvm-svn: 284607
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 11 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/combine-shl.ll | 1 |
2 files changed, 6 insertions, 6 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 9384d47b641..a95099a2867 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -4678,11 +4678,12 @@ SDValue DAGCombiner::visitSHL(SDNode *N) { } // fold (shl (mul x, c1), c2) -> (mul x, c1 << c2) - if (N1C && N0.getOpcode() == ISD::MUL && N0.getNode()->hasOneUse()) { - if (ConstantSDNode *N0C1 = isConstOrConstSplat(N0.getOperand(1))) { - if (SDValue Folded = - DAG.FoldConstantArithmetic(ISD::SHL, SDLoc(N1), VT, N0C1, N1C)) - return DAG.getNode(ISD::MUL, SDLoc(N), VT, N0.getOperand(0), Folded); + if (N0.getOpcode() == ISD::MUL && N0.getNode()->hasOneUse()) { + if (isConstantOrConstantVector(N1, /* No Opaques */ true) && + isConstantOrConstantVector(N0.getOperand(1), /* No Opaques */ true)) { + SDValue Shl = DAG.getNode(ISD::SHL, SDLoc(N1), VT, N0.getOperand(1), N1); + AddToWorklist(Shl.getNode()); + return DAG.getNode(ISD::MUL, SDLoc(N), VT, N0.getOperand(0), Shl); } } diff --git a/llvm/test/CodeGen/X86/combine-shl.ll b/llvm/test/CodeGen/X86/combine-shl.ll index ff5d4f013a4..dc3ca5e5229 100644 --- a/llvm/test/CodeGen/X86/combine-shl.ll +++ b/llvm/test/CodeGen/X86/combine-shl.ll @@ -572,7 +572,6 @@ define <4 x i32> @combine_vec_shl_mul1(<4 x i32> %x) { ; AVX-LABEL: combine_vec_shl_mul1: ; AVX: # BB#0: ; AVX-NEXT: vpmulld {{.*}}(%rip), %xmm0, %xmm0 -; AVX-NEXT: vpsllvd {{.*}}(%rip), %xmm0, %xmm0 ; AVX-NEXT: retq %1 = mul <4 x i32> %x, <i32 5, i32 6, i32 7, i32 8> %2 = shl <4 x i32> %1, <i32 1, i32 2, i32 3, i32 4> |
