diff options
author | Sam Clegg <sbc@chromium.org> | 2018-11-01 01:08:37 +0000 |
---|---|---|
committer | Sam Clegg <sbc@chromium.org> | 2018-11-01 01:08:37 +0000 |
commit | c1a3b9d51aa254462d42c8855ab49511181f780a (patch) | |
tree | c8ec4f6b19e5aa89bcf1f232b385d57494d34251 | |
parent | 2902989774ff8f5d7211b12dafff7e463a836daf (diff) | |
download | bcm5719-llvm-c1a3b9d51aa254462d42c8855ab49511181f780a.tar.gz bcm5719-llvm-c1a3b9d51aa254462d42c8855ab49511181f780a.zip |
[WebAssembly] Remove duplicate function. NFC.
Differential Revision: https://reviews.llvm.org/D53963
llvm-svn: 345806
-rw-r--r-- | lld/test/wasm/lto/signature-mismatch.ll | 2 | ||||
-rw-r--r-- | lld/test/wasm/signature-mismatch-weak.ll | 4 | ||||
-rw-r--r-- | lld/test/wasm/signature-mismatch.ll | 8 | ||||
-rw-r--r-- | lld/wasm/WriterUtils.cpp | 27 |
4 files changed, 13 insertions, 28 deletions
diff --git a/lld/test/wasm/lto/signature-mismatch.ll b/lld/test/wasm/lto/signature-mismatch.ll index 4b6b3b8f426..e48bb39cd8d 100644 --- a/lld/test/wasm/lto/signature-mismatch.ll +++ b/lld/test/wasm/lto/signature-mismatch.ll @@ -15,5 +15,5 @@ define void @_start() { ret void } -; CHECK: >>> defined as (I32) -> void in {{.*}}signature-mismatch.ll.tmp1.o +; CHECK: >>> defined as (i32) -> void in {{.*}}signature-mismatch.ll.tmp1.o ; CHECK: >>> defined as () -> void in lto.tmp diff --git a/lld/test/wasm/signature-mismatch-weak.ll b/lld/test/wasm/signature-mismatch-weak.ll index dbf73d1aa46..4d2b02cc9ed 100644 --- a/lld/test/wasm/signature-mismatch-weak.ll +++ b/lld/test/wasm/signature-mismatch-weak.ll @@ -14,5 +14,5 @@ entry: } ; CHECK: warning: function signature mismatch: weakFn -; CHECK-NEXT: >>> defined as () -> I32 in {{.*}}signature-mismatch-weak.ll.tmp.o -; CHECK-NEXT: >>> defined as () -> I64 in {{.*}}signature-mismatch-weak.ll.tmp.strong.o +; CHECK-NEXT: >>> defined as () -> i32 in {{.*}}signature-mismatch-weak.ll.tmp.o +; CHECK-NEXT: >>> defined as () -> i64 in {{.*}}signature-mismatch-weak.ll.tmp.strong.o diff --git a/lld/test/wasm/signature-mismatch.ll b/lld/test/wasm/signature-mismatch.ll index d750d4f6b35..8f13d644a7c 100644 --- a/lld/test/wasm/signature-mismatch.ll +++ b/lld/test/wasm/signature-mismatch.ll @@ -18,9 +18,9 @@ entry: declare i32 @ret32(i32, i64, i32) local_unnamed_addr #1 ; CHECK: error: function signature mismatch: ret32 -; CHECK-NEXT: >>> defined as (I32, I64, I32) -> I32 in {{.*}}.main.o -; CHECK-NEXT: >>> defined as (F32) -> I32 in {{.*}}.ret32.o +; CHECK-NEXT: >>> defined as (i32, i64, i32) -> i32 in {{.*}}.main.o +; CHECK-NEXT: >>> defined as (f32) -> i32 in {{.*}}.ret32.o ; REVERSE: error: function signature mismatch: ret32 -; REVERSE-NEXT: >>> defined as (F32) -> I32 in {{.*}}.ret32.o -; REVERSE-NEXT: >>> defined as (I32, I64, I32) -> I32 in {{.*}}.main.o +; REVERSE-NEXT: >>> defined as (f32) -> i32 in {{.*}}.ret32.o +; REVERSE-NEXT: >>> defined as (i32, i64, i32) -> i32 in {{.*}}.main.o diff --git a/lld/wasm/WriterUtils.cpp b/lld/wasm/WriterUtils.cpp index a92da743d96..6de48d91b85 100644 --- a/lld/wasm/WriterUtils.cpp +++ b/lld/wasm/WriterUtils.cpp @@ -19,21 +19,6 @@ using namespace llvm; using namespace llvm::wasm; using namespace lld::wasm; -static const char *valueTypeToString(ValType Type) { - switch (Type) { - case wasm::ValType::I32: - return "i32"; - case wasm::ValType::I64: - return "i64"; - case wasm::ValType::F32: - return "f32"; - case wasm::ValType::F64: - return "f64"; - default: - llvm_unreachable("invalid value type"); - } -} - namespace lld { void wasm::debugWrite(uint64_t Offset, const Twine &Msg) { @@ -75,7 +60,7 @@ void wasm::writeU32(raw_ostream &OS, uint32_t Number, const Twine &Msg) { void wasm::writeValueType(raw_ostream &OS, ValType Type, const Twine &Msg) { writeU8(OS, static_cast<uint8_t>(Type), - Msg + "[type: " + valueTypeToString(Type) + "]"); + Msg + "[type: " + toString(Type) + "]"); } void wasm::writeSig(raw_ostream &OS, const WasmSignature &Sig) { @@ -178,15 +163,15 @@ void wasm::writeExport(raw_ostream &OS, const WasmExport &Export) { std::string lld::toString(ValType Type) { switch (Type) { case ValType::I32: - return "I32"; + return "i32"; case ValType::I64: - return "I64"; + return "i64"; case ValType::F32: - return "F32"; + return "f32"; case ValType::F64: - return "F64"; + return "f64"; case ValType::V128: - return "V128"; + return "v128"; case ValType::EXCEPT_REF: return "except_ref"; } |