diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-05-15 05:31:14 +0000 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-05-15 05:31:14 +0000 |
commit | c18740976e53e847892ffcbc5278c4c7789a1289 (patch) | |
tree | de8df82e7fbc4ac01d5e73c4e438ceca83ec618e | |
parent | c31a45e62a2a4212a9bb23a7de20d4023e333dac (diff) | |
download | bcm5719-llvm-c18740976e53e847892ffcbc5278c4c7789a1289.tar.gz bcm5719-llvm-c18740976e53e847892ffcbc5278c4c7789a1289.zip |
Mark private unimplemented functions as deleted
Applies modernize-use-equals-delete to the LLDB code base and removes
the now redundant comments.
llvm-svn: 360751
-rw-r--r-- | lldb/include/lldb/Breakpoint/StoppointLocation.h | 2 | ||||
-rw-r--r-- | lldb/include/lldb/Host/macosx/HostInfoMacOSX.h | 4 | ||||
-rw-r--r-- | lldb/include/lldb/Symbol/Variable.h | 4 | ||||
-rw-r--r-- | lldb/include/lldb/Target/QueueList.h | 2 | ||||
-rw-r--r-- | lldb/include/lldb/Target/ThreadList.h | 2 | ||||
-rw-r--r-- | lldb/include/lldb/Target/UnwindAssembly.h | 2 | ||||
-rw-r--r-- | lldb/include/lldb/Utility/Event.h | 2 | ||||
-rw-r--r-- | lldb/include/lldb/Utility/SharingPtr.h | 14 | ||||
-rw-r--r-- | lldb/source/Host/macosx/cfcpp/CFCBundle.h | 4 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/MacOSX/MachTask.h | 4 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/PThreadEvent.h | 4 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/PseudoTerminal.h | 5 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/RNBContext.h | 5 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/RNBRemote.h | 3 | ||||
-rw-r--r-- | lldb/tools/debugserver/source/RNBSocket.h | 3 |
15 files changed, 27 insertions, 33 deletions
diff --git a/lldb/include/lldb/Breakpoint/StoppointLocation.h b/lldb/include/lldb/Breakpoint/StoppointLocation.h index 906cef54eee..3926f452e56 100644 --- a/lldb/include/lldb/Breakpoint/StoppointLocation.h +++ b/lldb/include/lldb/Breakpoint/StoppointLocation.h @@ -78,7 +78,7 @@ protected: private: // For StoppointLocation only DISALLOW_COPY_AND_ASSIGN(StoppointLocation); - StoppointLocation(); // Disallow default constructor + StoppointLocation() = delete; }; } // namespace lldb_private diff --git a/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h b/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h index d591776f4af..d49e27a8ee5 100644 --- a/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h +++ b/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h @@ -22,8 +22,8 @@ class HostInfoMacOSX : public HostInfoPosix { private: // Static class, unconstructable. - HostInfoMacOSX(); - ~HostInfoMacOSX(); + HostInfoMacOSX() = delete; + ~HostInfoMacOSX() = delete; public: static llvm::VersionTuple GetOSVersion(); diff --git a/lldb/include/lldb/Symbol/Variable.h b/lldb/include/lldb/Symbol/Variable.h index ea46df703fb..12daecfc04e 100644 --- a/lldb/include/lldb/Symbol/Variable.h +++ b/lldb/include/lldb/Symbol/Variable.h @@ -128,8 +128,8 @@ protected: m_static_member : 1; // Non-zero if variable is static member of a class // or struct. private: - Variable(const Variable &rhs); - Variable &operator=(const Variable &rhs); + Variable(const Variable &rhs) = delete; + Variable &operator=(const Variable &rhs) = delete; }; } // namespace lldb_private diff --git a/lldb/include/lldb/Target/QueueList.h b/lldb/include/lldb/Target/QueueList.h index 7029fa28f6e..761107e41de 100644 --- a/lldb/include/lldb/Target/QueueList.h +++ b/lldb/include/lldb/Target/QueueList.h @@ -102,7 +102,7 @@ protected: std::mutex m_mutex; private: - QueueList(); + QueueList() = delete; }; } // namespace lldb_private diff --git a/lldb/include/lldb/Target/ThreadList.h b/lldb/include/lldb/Target/ThreadList.h index dcbd9aa8356..64ddf5aea50 100644 --- a/lldb/include/lldb/Target/ThreadList.h +++ b/lldb/include/lldb/Target/ThreadList.h @@ -151,7 +151,7 @@ protected: std::vector<lldb::tid_t> m_expression_tid_stack; private: - ThreadList(); + ThreadList() = delete; }; } // namespace lldb_private diff --git a/lldb/include/lldb/Target/UnwindAssembly.h b/lldb/include/lldb/Target/UnwindAssembly.h index 7c42df2d6af..a70aef6e93c 100644 --- a/lldb/include/lldb/Target/UnwindAssembly.h +++ b/lldb/include/lldb/Target/UnwindAssembly.h @@ -44,7 +44,7 @@ protected: ArchSpec m_arch; private: - UnwindAssembly(); // Outlaw default constructor + UnwindAssembly() = delete; DISALLOW_COPY_AND_ASSIGN(UnwindAssembly); }; diff --git a/lldb/include/lldb/Utility/Event.h b/lldb/include/lldb/Utility/Event.h index c0e4e972feb..3743c647379 100644 --- a/lldb/include/lldb/Utility/Event.h +++ b/lldb/include/lldb/Utility/Event.h @@ -245,7 +245,7 @@ private: lldb::EventDataSP m_data_sp; // User specific data for this event DISALLOW_COPY_AND_ASSIGN(Event); - Event(); // Disallow default constructor + Event() = delete; }; } // namespace lldb_private diff --git a/lldb/include/lldb/Utility/SharingPtr.h b/lldb/include/lldb/Utility/SharingPtr.h index 5515103e6ce..e4ab3d27a69 100644 --- a/lldb/include/lldb/Utility/SharingPtr.h +++ b/lldb/include/lldb/Utility/SharingPtr.h @@ -35,8 +35,8 @@ namespace lldb_private { namespace imp { class shared_count { - shared_count(const shared_count &); - shared_count &operator=(const shared_count &); + shared_count(const shared_count &) = delete; + shared_count &operator=(const shared_count &) = delete; public: explicit shared_count(long refs = 0) : shared_owners_(refs) {} @@ -66,10 +66,8 @@ public: private: void on_zero_shared() override; - // Outlaw copy constructor and assignment operator to keep effective C++ - // warnings down to a minimum - shared_ptr_pointer(const shared_ptr_pointer &); - shared_ptr_pointer &operator=(const shared_ptr_pointer &); + shared_ptr_pointer(const shared_ptr_pointer &) = delete; + shared_ptr_pointer &operator=(const shared_ptr_pointer &) = delete; }; template <class T> void shared_ptr_pointer<T>::on_zero_shared() { @@ -455,8 +453,8 @@ protected: friend class IntrusiveSharingPtr<T>; private: - ReferenceCountedBase(const ReferenceCountedBase &); - ReferenceCountedBase &operator=(const ReferenceCountedBase &); + ReferenceCountedBase(const ReferenceCountedBase &) = delete; + ReferenceCountedBase &operator=(const ReferenceCountedBase &) = delete; }; template <class T> void lldb_private::ReferenceCountedBase<T>::add_shared() { diff --git a/lldb/source/Host/macosx/cfcpp/CFCBundle.h b/lldb/source/Host/macosx/cfcpp/CFCBundle.h index 9ff58fba854..014552ab18f 100644 --- a/lldb/source/Host/macosx/cfcpp/CFCBundle.h +++ b/lldb/source/Host/macosx/cfcpp/CFCBundle.h @@ -31,9 +31,9 @@ public: private: // Disallow copy and assignment constructors - CFCBundle(const CFCBundle &); + CFCBundle(const CFCBundle &) = delete; - const CFCBundle &operator=(const CFCBundle &); + const CFCBundle &operator=(const CFCBundle &) = delete; }; #endif // #ifndef CoreFoundationCPP_CFBundle_h_ diff --git a/lldb/tools/debugserver/source/MacOSX/MachTask.h b/lldb/tools/debugserver/source/MacOSX/MachTask.h index a933bffc8a0..c975e15a555 100644 --- a/lldb/tools/debugserver/source/MacOSX/MachTask.h +++ b/lldb/tools/debugserver/source/MacOSX/MachTask.h @@ -102,8 +102,8 @@ protected: allocation_collection m_allocations; private: - MachTask(const MachTask &); // Outlaw - MachTask &operator=(const MachTask &rhs); // Outlaw + MachTask(const MachTask &) = delete; + MachTask &operator=(const MachTask &rhs) = delete; }; #endif // __MachTask_h__ diff --git a/lldb/tools/debugserver/source/PThreadEvent.h b/lldb/tools/debugserver/source/PThreadEvent.h index 5689cbfb9ca..f81798de5c7 100644 --- a/lldb/tools/debugserver/source/PThreadEvent.h +++ b/lldb/tools/debugserver/source/PThreadEvent.h @@ -54,8 +54,8 @@ protected: uint32_t m_reset_ack_mask; private: - PThreadEvent(const PThreadEvent &); // Outlaw copy constructor - PThreadEvent &operator=(const PThreadEvent &rhs); + PThreadEvent(const PThreadEvent &) = delete; + PThreadEvent &operator=(const PThreadEvent &rhs) = delete; }; #endif // #ifndef __PThreadEvent_h__ diff --git a/lldb/tools/debugserver/source/PseudoTerminal.h b/lldb/tools/debugserver/source/PseudoTerminal.h index e4093bd98e9..e3324c1c358 100644 --- a/lldb/tools/debugserver/source/PseudoTerminal.h +++ b/lldb/tools/debugserver/source/PseudoTerminal.h @@ -72,9 +72,8 @@ protected: int m_slave_fd; private: - // Outlaw copy and assignment constructors - PseudoTerminal(const PseudoTerminal &rhs); - PseudoTerminal &operator=(const PseudoTerminal &rhs); + PseudoTerminal(const PseudoTerminal &rhs) = delete; + PseudoTerminal &operator=(const PseudoTerminal &rhs) = delete; }; #endif // #ifndef __PseudoTerminal_h__ diff --git a/lldb/tools/debugserver/source/RNBContext.h b/lldb/tools/debugserver/source/RNBContext.h index 9159057329f..946dfb2eb10 100644 --- a/lldb/tools/debugserver/source/RNBContext.h +++ b/lldb/tools/debugserver/source/RNBContext.h @@ -149,9 +149,8 @@ protected: static void *ThreadFunctionProcessStatus(void *arg); private: - // Outlaw copy and assignment operators - RNBContext(const RNBContext &rhs); - RNBContext &operator=(const RNBContext &rhs); + RNBContext(const RNBContext &rhs) = delete; + RNBContext &operator=(const RNBContext &rhs) = delete; }; #endif // #ifndef __RNBContext_h__ diff --git a/lldb/tools/debugserver/source/RNBRemote.h b/lldb/tools/debugserver/source/RNBRemote.h index 1fb309bbc44..88d82091130 100644 --- a/lldb/tools/debugserver/source/RNBRemote.h +++ b/lldb/tools/debugserver/source/RNBRemote.h @@ -264,8 +264,7 @@ public: RNBSocket &Comm() { return m_comm; } private: - // Outlaw some constructors - RNBRemote(const RNBRemote &); + RNBRemote(const RNBRemote &) = delete; protected: rnb_err_t GetCommData(); diff --git a/lldb/tools/debugserver/source/RNBSocket.h b/lldb/tools/debugserver/source/RNBSocket.h index da6c6d88874..2f68eb00f37 100644 --- a/lldb/tools/debugserver/source/RNBSocket.h +++ b/lldb/tools/debugserver/source/RNBSocket.h @@ -59,8 +59,7 @@ public: int option_value); private: - // Outlaw some constructors - RNBSocket(const RNBSocket &); + RNBSocket(const RNBSocket &) = delete; protected: rnb_err_t ClosePort(int &fd, bool save_errno); |