diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2019-04-16 08:06:56 +0000 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2019-04-16 08:06:56 +0000 |
| commit | bef588ce11ef83b3d82c27fe8ceb67bf693c0b79 (patch) | |
| tree | f8df9c34cb546f574e3a7c82502c25b17ef8863c | |
| parent | 6ae05777b8c331b793a40c7af24990be16b34efd (diff) | |
| download | bcm5719-llvm-bef588ce11ef83b3d82c27fe8ceb67bf693c0b79.tar.gz bcm5719-llvm-bef588ce11ef83b3d82c27fe8ceb67bf693c0b79.zip | |
Fix typo in ArmUnwindInfo::GetUnwindPlan
Summary:
As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We want to check for `11010nnn`,
so the proper value we want to compare against is `0xd0` (`0xc0` would check for the value `11000nnn` which we
already checked for above as described in the bug report).
Reviewers: #lldb, jasonmolenda
Reviewed By: #lldb, jasonmolenda
Subscribers: jasonmolenda, javed.absar, kristof.beyls, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D60655
llvm-svn: 358479
| -rw-r--r-- | lldb/source/Symbol/ArmUnwindInfo.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Symbol/ArmUnwindInfo.cpp b/lldb/source/Symbol/ArmUnwindInfo.cpp index 3ab1bbabbe0..b9fd84b1e70 100644 --- a/lldb/source/Symbol/ArmUnwindInfo.cpp +++ b/lldb/source/Symbol/ArmUnwindInfo.cpp @@ -304,7 +304,7 @@ bool ArmUnwindInfo::GetUnwindPlan(Target &target, const Address &addr, // 11001yyy // Spare (yyy != 000, 001) return false; - } else if ((byte1 & 0xf8) == 0xc0) { + } else if ((byte1 & 0xf8) == 0xd0) { // 11010nnn // Pop VFP double-precision registers D[8]-D[8+nnn] saved (as if) by // FSTMFDD (see remark d) |
