diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-12-08 06:46:18 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-12-08 06:46:18 +0000 |
| commit | bb5008a32ac913144ba8721eb99f09f55389de3b (patch) | |
| tree | 299ecfe69ea241bb3dc6ea6bbde4db0f179cc6bb | |
| parent | 897bc033056c5d6933a45a576a4bc3133e618f97 (diff) | |
| download | bcm5719-llvm-bb5008a32ac913144ba8721eb99f09f55389de3b.tar.gz bcm5719-llvm-bb5008a32ac913144ba8721eb99f09f55389de3b.zip | |
Fix for PR5707: make sure implicit copy constructors initialize the vtable
pointer.
llvm-svn: 90840
| -rw-r--r-- | clang/lib/CodeGen/CGCXX.cpp | 6 | ||||
| -rw-r--r-- | clang/lib/CodeGen/CodeGenFunction.h | 2 | ||||
| -rw-r--r-- | clang/test/CodeGenCXX/copy-constructor-synthesis-2.cpp | 7 |
3 files changed, 15 insertions, 0 deletions
diff --git a/clang/lib/CodeGen/CGCXX.cpp b/clang/lib/CodeGen/CGCXX.cpp index 0b77584dd93..bd166d08efe 100644 --- a/clang/lib/CodeGen/CGCXX.cpp +++ b/clang/lib/CodeGen/CGCXX.cpp @@ -1572,6 +1572,8 @@ CodeGenFunction::SynthesizeCXXCopyConstructor(const CXXConstructorDecl *Ctor, EmitAggregateCopy(LHS.getAddress(), RHS.getAddress(), Field->getType()); } } + + InitializeVtablePtrs(ClassDecl); FinishFunction(); } @@ -1812,6 +1814,10 @@ void CodeGenFunction::EmitCtorPrologue(const CXXConstructorDecl *CD, PopCXXTemporary(); } + InitializeVtablePtr(ClassDecl); +} + +void CodeGenFunction::InitializeVtablePtrs(const CXXRecordDecl *ClassDecl) { if (!ClassDecl->isDynamicClass()) return; diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h index ead2b5df7d3..854eb53ec29 100644 --- a/clang/lib/CodeGen/CodeGenFunction.h +++ b/clang/lib/CodeGen/CodeGenFunction.h @@ -468,6 +468,8 @@ public: void EmitCtorPrologue(const CXXConstructorDecl *CD, CXXCtorType Type); + void InitializeVtablePtrs(const CXXRecordDecl *ClassDecl); + void SynthesizeCXXCopyConstructor(const CXXConstructorDecl *Ctor, CXXCtorType Type, llvm::Function *Fn, diff --git a/clang/test/CodeGenCXX/copy-constructor-synthesis-2.cpp b/clang/test/CodeGenCXX/copy-constructor-synthesis-2.cpp new file mode 100644 index 00000000000..b4add46db85 --- /dev/null +++ b/clang/test/CodeGenCXX/copy-constructor-synthesis-2.cpp @@ -0,0 +1,7 @@ +// RUN: clang-cc -emit-llvm -o - %s | FileCheck %s + +struct A { virtual void a(); }; +A x(A& y) { return y; } + +// CHECK: define linkonce_odr void @_ZN1AC1ERKS_( +// CHECK: store i8** getelementptr inbounds ([3 x i8*]* @_ZTV1A, i64 0, i64 2) |

