summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorge Rimar <grimar@accesssoftek.com>2019-04-23 14:21:31 +0000
committerGeorge Rimar <grimar@accesssoftek.com>2019-04-23 14:21:31 +0000
commitbb2079b7e13a22bebfba5180114e76a63cc07649 (patch)
tree45a9732913e7a1471d0651e7c8bd6316183309fb
parent0e4992ce27b950f2f9a94cd10c27162e74a6b584 (diff)
downloadbcm5719-llvm-bb2079b7e13a22bebfba5180114e76a63cc07649.tar.gz
bcm5719-llvm-bb2079b7e13a22bebfba5180114e76a63cc07649.zip
[LLD][ELF] - Remove dynamic-section-sh_size.elf binary, convert test to yaml. NFCI.
dynamic-section-sh_size.elf was introduced in D25090. Now it is possible to use yaml2obj instead. That is what this patch does. Also I added one more case of a possibly broken .dynamic section just in case. llvm-svn: 358990
-rw-r--r--lld/test/ELF/invalid/Inputs/dynamic-section-sh_size.elfbin482 -> 0 bytes
-rw-r--r--lld/test/ELF/invalid/dynamic-section-broken.test36
-rw-r--r--lld/test/ELF/invalid/dynamic-section-size.s4
3 files changed, 36 insertions, 4 deletions
diff --git a/lld/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf b/lld/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf
deleted file mode 100644
index ea35dba9517..00000000000
--- a/lld/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf
+++ /dev/null
Binary files differ
diff --git a/lld/test/ELF/invalid/dynamic-section-broken.test b/lld/test/ELF/invalid/dynamic-section-broken.test
new file mode 100644
index 00000000000..5676e977edc
--- /dev/null
+++ b/lld/test/ELF/invalid/dynamic-section-broken.test
@@ -0,0 +1,36 @@
+## .dynamic section has invalid sh_entsize, check we report it.
+# RUN: yaml2obj -docnum=1 %s -o %t.so
+# RUN: not ld.lld %t.so -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR1
+# ERR1: error: {{.*}}.so: invalid sh_entsize
+
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data: ELFDATA2LSB
+ Type: ET_DYN
+ Machine: EM_X86_64
+Sections:
+ - Name: .dynamic
+ Type: SHT_DYNAMIC
+ Flags: [ SHF_ALLOC ]
+ Link: .strtab
+ EntSize: 0x123
+
+## The .dynamic section has invalid sh_size, which is too short and
+## even less than entry size. Check we report it.
+# RUN: yaml2obj -docnum=2 %s -o %t.so
+# RUN: not ld.lld %t.so -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR2
+# ERR2: error: {{.*}}.so: size is not a multiple of sh_entsize
+
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data: ELFDATA2LSB
+ Type: ET_DYN
+ Machine: EM_X86_64
+Sections:
+ - Name: .dynamic
+ Type: SHT_DYNAMIC
+ Flags: [ SHF_ALLOC ]
+ Link: .strtab
+ Content: "00"
diff --git a/lld/test/ELF/invalid/dynamic-section-size.s b/lld/test/ELF/invalid/dynamic-section-size.s
deleted file mode 100644
index 58a7d0688c2..00000000000
--- a/lld/test/ELF/invalid/dynamic-section-size.s
+++ /dev/null
@@ -1,4 +0,0 @@
-## dynamic-section-sh_size.elf has incorrect sh_size of dynamic section.
-# RUN: not ld.lld %p/Inputs/dynamic-section-sh_size.elf -o /dev/null 2>&1 | \
-# RUN: FileCheck %s
-# CHECK: error: {{.*}}: invalid sh_entsize
OpenPOWER on IntegriCloud