summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Jasper <djasper@google.com>2014-11-02 22:00:57 +0000
committerDaniel Jasper <djasper@google.com>2014-11-02 22:00:57 +0000
commitb9d3db6b1be72c1b640082514e2eda789e2dcd61 (patch)
tree2d84f13b33c4314dd0f35ff39961f04bc537a4bf
parent7bd618f5aa91fff0dbff9350793a3e06afe3f4b9 (diff)
downloadbcm5719-llvm-b9d3db6b1be72c1b640082514e2eda789e2dcd61.tar.gz
bcm5719-llvm-b9d3db6b1be72c1b640082514e2eda789e2dcd61.zip
clang-format: [Java] Add space between "synchronized" and "(".
Before: synchronized(mData) { // ... } After: synchronized (mData) { // ... } This fixes llvm.org/PR21455. llvm-svn: 221110
-rw-r--r--clang/lib/Format/TokenAnnotator.cpp3
-rw-r--r--clang/unittests/Format/FormatTestJava.cpp6
2 files changed, 9 insertions, 0 deletions
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp
index a131397fb52..1056d434200 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -1680,6 +1680,9 @@ bool TokenAnnotator::spaceRequiredBefore(const AnnotatedLine &Line,
} else if (Style.Language == FormatStyle::LK_JavaScript) {
if (Left.TokenText == "var")
return true;
+ } else if (Style.Language == FormatStyle::LK_Java) {
+ if (Left.TokenText == "synchronized" && Right.is(tok::l_paren))
+ return Style.SpaceBeforeParens != FormatStyle::SBPO_Never;
}
if (Right.Tok.getIdentifierInfo() && Left.Tok.getIdentifierInfo())
return true; // Never ever merge two identifiers.
diff --git a/clang/unittests/Format/FormatTestJava.cpp b/clang/unittests/Format/FormatTestJava.cpp
index bcbf2831efa..2b05ca49374 100644
--- a/clang/unittests/Format/FormatTestJava.cpp
+++ b/clang/unittests/Format/FormatTestJava.cpp
@@ -157,5 +157,11 @@ TEST_F(FormatTestJava, TryCatchFinally) {
"}");
}
+TEST_F(FormatTestJava, SynchronizedKeyword) {
+ verifyFormat("synchronized (mData) {\n"
+ " // ...\n"
+ "}");
+}
+
} // end namespace tooling
} // end namespace clang
OpenPOWER on IntegriCloud