diff options
author | Sean Callanan <scallanan@apple.com> | 2011-10-13 16:49:47 +0000 |
---|---|---|
committer | Sean Callanan <scallanan@apple.com> | 2011-10-13 16:49:47 +0000 |
commit | b96ff33b0e4b73264b270ace256ffad8ab0522cb (patch) | |
tree | 250cadd8abc1a474b51144eae6341426aa753016 | |
parent | adcf7c92035e49e27065d577e58bc5d66e8aef4b (diff) | |
download | bcm5719-llvm-b96ff33b0e4b73264b270ace256ffad8ab0522cb.tar.gz bcm5719-llvm-b96ff33b0e4b73264b270ace256ffad8ab0522cb.zip |
Removed namespace qualification from symbol queries.
llvm-svn: 141866
-rw-r--r-- | lldb/include/lldb/Core/Module.h | 1 | ||||
-rw-r--r-- | lldb/include/lldb/Expression/ClangExpressionDeclMap.h | 10 | ||||
-rw-r--r-- | lldb/source/Breakpoint/BreakpointResolverName.cpp | 2 | ||||
-rw-r--r-- | lldb/source/Core/AddressResolverName.cpp | 1 | ||||
-rw-r--r-- | lldb/source/Core/Module.cpp | 2 | ||||
-rw-r--r-- | lldb/source/Core/ModuleList.cpp | 2 | ||||
-rw-r--r-- | lldb/source/Expression/ClangExpressionDeclMap.cpp | 20 | ||||
-rw-r--r-- | lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp | 2 |
8 files changed, 11 insertions, 29 deletions
diff --git a/lldb/include/lldb/Core/Module.h b/lldb/include/lldb/Core/Module.h index dc7befa9928..c5eae878d2c 100644 --- a/lldb/include/lldb/Core/Module.h +++ b/lldb/include/lldb/Core/Module.h @@ -161,7 +161,6 @@ public: size_t FindSymbolsWithNameAndType (const ConstString &name, - const ClangNamespaceDecl *namespace_decl, lldb::SymbolType symbol_type, SymbolContextList &sc_list); diff --git a/lldb/include/lldb/Expression/ClangExpressionDeclMap.h b/lldb/include/lldb/Expression/ClangExpressionDeclMap.h index bc7c4a3d8f1..a0cd4fecce7 100644 --- a/lldb/include/lldb/Expression/ClangExpressionDeclMap.h +++ b/lldb/include/lldb/Expression/ClangExpressionDeclMap.h @@ -889,23 +889,15 @@ private: /// @param[in] target /// The target to use as the basis for the search. /// - /// @param[in] module - /// If non-NULL, the module to query. - /// /// @param[in] name /// The name as a plain C string. /// - /// @param[in] namespace_decl - /// If valid and module is non-NULL, the parent namespace. - /// /// @return /// The LLDB Symbol found, or NULL if none was found. //--------------------------------------------------------- Symbol * FindGlobalDataSymbol (Target &target, - lldb::ModuleSP &module, - const ConstString &name, - ClangNamespaceDecl *namespace_decl); + const ConstString &name); //------------------------------------------------------------------ /// Given a target, find a variable that matches the given name and diff --git a/lldb/source/Breakpoint/BreakpointResolverName.cpp b/lldb/source/Breakpoint/BreakpointResolverName.cpp index 7a9593b7cb2..77032e9aa47 100644 --- a/lldb/source/Breakpoint/BreakpointResolverName.cpp +++ b/lldb/source/Breakpoint/BreakpointResolverName.cpp @@ -140,7 +140,7 @@ BreakpointResolverName::SearchCallback if (num_functions == 0 && !filter_by_cu) { if (m_func_name_type_mask & (eFunctionNameTypeBase | eFunctionNameTypeFull | eFunctionNameTypeAuto)) - context.module_sp->FindSymbolsWithNameAndType (m_func_name, NULL, eSymbolTypeCode, sym_list); + context.module_sp->FindSymbolsWithNameAndType (m_func_name, eSymbolTypeCode, sym_list); } } break; diff --git a/lldb/source/Core/AddressResolverName.cpp b/lldb/source/Core/AddressResolverName.cpp index baf62f21a2f..82187004199 100644 --- a/lldb/source/Core/AddressResolverName.cpp +++ b/lldb/source/Core/AddressResolverName.cpp @@ -111,7 +111,6 @@ AddressResolverName::SearchCallback if (context.module_sp) { context.module_sp->FindSymbolsWithNameAndType (m_func_name, - NULL, eSymbolTypeCode, sym_list); context.module_sp->FindFunctions (m_func_name, diff --git a/lldb/source/Core/Module.cpp b/lldb/source/Core/Module.cpp index 429362c6ab5..3f8a7635144 100644 --- a/lldb/source/Core/Module.cpp +++ b/lldb/source/Core/Module.cpp @@ -687,7 +687,7 @@ Module::SymbolIndicesToSymbolContextList (Symtab *symtab, std::vector<uint32_t> } size_t -Module::FindSymbolsWithNameAndType (const ConstString &name, const ClangNamespaceDecl *namespace_decl, SymbolType symbol_type, SymbolContextList &sc_list) +Module::FindSymbolsWithNameAndType (const ConstString &name, SymbolType symbol_type, SymbolContextList &sc_list) { // No need to protect this call using m_mutex all other method calls are // already thread safe. diff --git a/lldb/source/Core/ModuleList.cpp b/lldb/source/Core/ModuleList.cpp index 7c35c9b6ed3..f3a2f0fbfa6 100644 --- a/lldb/source/Core/ModuleList.cpp +++ b/lldb/source/Core/ModuleList.cpp @@ -254,7 +254,7 @@ ModuleList::FindSymbolsWithNameAndType (const ConstString &name, sc_list.Clear(); collection::iterator pos, end = m_modules.end(); for (pos = m_modules.begin(); pos != end; ++pos) - (*pos)->FindSymbolsWithNameAndType (name, NULL, symbol_type, sc_list); + (*pos)->FindSymbolsWithNameAndType (name, symbol_type, sc_list); return sc_list.GetSize(); } diff --git a/lldb/source/Expression/ClangExpressionDeclMap.cpp b/lldb/source/Expression/ClangExpressionDeclMap.cpp index 44f40d6d4af..fbeac4e6f37 100644 --- a/lldb/source/Expression/ClangExpressionDeclMap.cpp +++ b/lldb/source/Expression/ClangExpressionDeclMap.cpp @@ -631,7 +631,7 @@ FindCodeSymbolInContext ) { if (sym_ctx.module_sp) - sym_ctx.module_sp->FindSymbolsWithNameAndType(name, NULL, eSymbolTypeCode, sc_list); + sym_ctx.module_sp->FindSymbolsWithNameAndType(name, eSymbolTypeCode, sc_list); if (!sc_list.GetSize()) sym_ctx.target_sp->GetImages().FindSymbolsWithNameAndType(name, eSymbolTypeCode, sc_list); @@ -1950,22 +1950,14 @@ Symbol * ClangExpressionDeclMap::FindGlobalDataSymbol ( Target &target, - ModuleSP &module, - const ConstString &name, - ClangNamespaceDecl *namespace_decl + const ConstString &name ) { SymbolContextList sc_list; - if (module && namespace_decl) - module->FindSymbolsWithNameAndType(name, - namespace_decl, - eSymbolTypeData, - sc_list); - else - target.GetImages().FindSymbolsWithNameAndType(name, - eSymbolTypeData, - sc_list); + target.GetImages().FindSymbolsWithNameAndType(name, + eSymbolTypeData, + sc_list); if (sc_list.GetSize()) { @@ -2408,7 +2400,7 @@ ClangExpressionDeclMap::FindExternalVisibleDecls (NameSearchContext &context, // We couldn't find a non-symbol variable for this. Now we'll hunt for a generic // data symbol, and -- if it is found -- treat it as a variable. - Symbol *data_symbol = FindGlobalDataSymbol(*target, module_sp, name, &namespace_decl); + Symbol *data_symbol = FindGlobalDataSymbol(*target, name); if (data_symbol) { diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp index 5819defb273..0d1289057ce 100644 --- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -1696,7 +1696,7 @@ ObjectFileMachO::GetEntryPointAddress () SymbolContextList contexts; SymbolContext context; - if (!m_module->FindSymbolsWithNameAndType(ConstString ("start"), NULL, eSymbolTypeCode, contexts)) + if (!m_module->FindSymbolsWithNameAndType(ConstString ("start"), eSymbolTypeCode, contexts)) return m_entry_point_address; contexts.GetContextAtIndex(0, context); |