diff options
author | Ulrich Weigand <ulrich.weigand@de.ibm.com> | 2015-03-30 13:46:59 +0000 |
---|---|---|
committer | Ulrich Weigand <ulrich.weigand@de.ibm.com> | 2015-03-30 13:46:59 +0000 |
commit | b8d76fb7ca255e7885d754a4df8c4715a4aa7a3f (patch) | |
tree | 699a64fff46ed906b5c0e84b267b8e58bf5d9c2c | |
parent | 58bb263eed58b8b3cd8b92794a58fe9344e476f1 (diff) | |
download | bcm5719-llvm-b8d76fb7ca255e7885d754a4df8c4715a4aa7a3f.tar.gz bcm5719-llvm-b8d76fb7ca255e7885d754a4df8c4715a4aa7a3f.zip |
[SystemZ] Fix LLVM crash on unoptimized code
Compiling the following function with -O0 would crash, since LLVM would
hit an assertion in getTestUnderMaskCond:
int test(unsigned long x)
{
return x >= 0 && x <= 15;
}
Fixed by detecting the case in the caller of getTestUnderMaskCond.
llvm-svn: 233541
-rw-r--r-- | llvm/lib/Target/SystemZ/SystemZISelLowering.cpp | 2 | ||||
-rw-r--r-- | llvm/test/CodeGen/SystemZ/int-cmp-50.ll | 30 |
2 files changed, 32 insertions, 0 deletions
diff --git a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp index 0ca8bcd2df4..c0faa911784 100644 --- a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp +++ b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp @@ -1530,6 +1530,8 @@ static void adjustForTestUnderMask(SelectionDAG &DAG, Comparison &C) { MaskVal = -(CmpVal & -CmpVal); NewC.ICmpType = SystemZICMP::UnsignedOnly; } + if (!MaskVal) + return; // Check whether the combination of mask, comparison value and comparison // type are suitable. diff --git a/llvm/test/CodeGen/SystemZ/int-cmp-50.ll b/llvm/test/CodeGen/SystemZ/int-cmp-50.ll new file mode 100644 index 00000000000..287ac2c49a7 --- /dev/null +++ b/llvm/test/CodeGen/SystemZ/int-cmp-50.ll @@ -0,0 +1,30 @@ +; Verify that we do not crash on always-true conditions +; +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 -O0 +; +; This test was compiled using clang -O0 from the following source code: +; +; int test(unsigned long x) +; { +; return x >= 0 && x <= 15; +; } + +define signext i32 @test(i64 %x) { +entry: + %x.addr = alloca i64, align 8 + store i64 %x, i64* %x.addr, align 8 + %0 = load i64, i64* %x.addr, align 8 + %cmp = icmp uge i64 %0, 0 + br i1 %cmp, label %land.rhs, label %land.end + +land.rhs: ; preds = %entry + %1 = load i64, i64* %x.addr, align 8 + %cmp1 = icmp ule i64 %1, 15 + br label %land.end + +land.end: ; preds = %land.rhs, %entry + %2 = phi i1 [ false, %entry ], [ %cmp1, %land.rhs ] + %land.ext = zext i1 %2 to i32 + ret i32 %land.ext +} + |