diff options
author | Mark de Wever <koraq@xs4all.nl> | 2019-12-17 21:56:04 +0100 |
---|---|---|
committer | Mark de Wever <koraq@xs4all.nl> | 2019-12-17 21:56:04 +0100 |
commit | b750486c5d96320daf77a9760166f78b4a0c942e (patch) | |
tree | dcab7d3c483e8342936bfcb6a57b618ed7bc8756 | |
parent | 3ec6128daeeaadde7dd2eca8b343a56f60a8364d (diff) | |
download | bcm5719-llvm-b750486c5d96320daf77a9760166f78b4a0c942e.tar.gz bcm5719-llvm-b750486c5d96320daf77a9760166f78b4a0c942e.zip |
[Driver] Avoid copies in range-based for loops
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.
Differential Revision: https://reviews.llvm.org/D71527
-rw-r--r-- | clang/lib/Driver/Driver.cpp | 2 | ||||
-rw-r--r-- | clang/lib/Driver/ToolChain.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp index 9139915761d..f2b23431551 100644 --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -744,7 +744,7 @@ static bool searchForFile(SmallVectorImpl<char> &FilePath, ArrayRef<std::string> Dirs, StringRef FileName) { SmallString<128> WPath; - for (const StringRef &Dir : Dirs) { + for (const std::string &Dir : Dirs) { if (Dir.empty()) continue; WPath.clear(); diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp index ba4128e0622..cab97b1a601 100644 --- a/clang/lib/Driver/ToolChain.cpp +++ b/clang/lib/Driver/ToolChain.cpp @@ -850,7 +850,7 @@ void ToolChain::addExternCSystemIncludeIfExists(const ArgList &DriverArgs, /*static*/ void ToolChain::addSystemIncludes(const ArgList &DriverArgs, ArgStringList &CC1Args, ArrayRef<StringRef> Paths) { - for (const auto Path : Paths) { + for (const auto &Path : Paths) { CC1Args.push_back("-internal-isystem"); CC1Args.push_back(DriverArgs.MakeArgString(Path)); } |