summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSaar Raz <saar@raz.email>2020-01-22 02:41:37 +0200
committerSaar Raz <saar@raz.email>2020-01-24 02:28:25 +0200
commitb597c9e46cb5993edbb872586022dd9ca36cfd8d (patch)
tree0783096eeb609e4a3ebbde444e37794138687348
parentfe039ecc2d7467ee02a30a9b32d99256e468a671 (diff)
downloadbcm5719-llvm-b597c9e46cb5993edbb872586022dd9ca36cfd8d.tar.gz
bcm5719-llvm-b597c9e46cb5993edbb872586022dd9ca36cfd8d.zip
[clang-tidy] Fix check for generic lambda invented template parameters
clang-tidy previously relied on there being no identifier for a TemplateTypeParmDecl for checking whether 'decltype(x)' should be inserted, instead of checking whether or not it is implicit. D65042 added new names for invented generic lambda template parameters, rendering that check incorrect. (cherry picked from commit 5fdad8e3f803adce501ca25118f325184e54018d)
-rw-r--r--clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp
index bf6f2f6ed03..8953f95159a 100644
--- a/clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp
@@ -33,7 +33,7 @@ static void replaceMoveWithForward(const UnresolvedLookupExpr *Callee,
if (CallRange.isValid()) {
const std::string TypeName =
- TypeParmDecl->getIdentifier()
+ (TypeParmDecl->getIdentifier() && !TypeParmDecl->isImplicit())
? TypeParmDecl->getName().str()
: (llvm::Twine("decltype(") + ParmVar->getName() + ")").str();
OpenPOWER on IntegriCloud