diff options
author | Dan Gohman <dan433584@gmail.com> | 2016-05-18 14:29:42 +0000 |
---|---|---|
committer | Dan Gohman <dan433584@gmail.com> | 2016-05-18 14:29:42 +0000 |
commit | b4c3c38276cfdf0bf4d101c1574827e12995732a (patch) | |
tree | d63815a11b1639f2652f3e41d76dbcf49d87ebc4 | |
parent | 9829df5d56dcaa55742a05bab60eb29c7615a163 (diff) | |
download | bcm5719-llvm-b4c3c38276cfdf0bf4d101c1574827e12995732a.tar.gz bcm5719-llvm-b4c3c38276cfdf0bf4d101c1574827e12995732a.zip |
[WebAssembly] Don't expand divisions by constants.
Don't expand divisions by constants if it would require multiple instructions.
The current assumption is that engines will perform the desired optimizations.
llvm-svn: 269930
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp | 6 | ||||
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h | 1 | ||||
-rw-r--r-- | llvm/test/CodeGen/WebAssembly/divrem-constant.ll | 62 |
3 files changed, 69 insertions, 0 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp index d43bf1ab8ec..faaeff08593 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp @@ -243,6 +243,12 @@ bool WebAssemblyTargetLowering::allowsMisalignedMemoryAccesses( return true; } +bool WebAssemblyTargetLowering::isIntDivCheap(EVT VT, AttributeSet Attr) const { + // The current thinking is that wasm engines will perform this optimization, + // so we can save on code size. + return true; +} + //===----------------------------------------------------------------------===// // WebAssembly Lowering private implementation. //===----------------------------------------------------------------------===// diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h index 5b538fda479..e5d2fa43ad4 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h +++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h @@ -58,6 +58,7 @@ class WebAssemblyTargetLowering final : public TargetLowering { unsigned AS) const override; bool allowsMisalignedMemoryAccesses(EVT, unsigned AddrSpace, unsigned Align, bool *Fast) const override; + bool isIntDivCheap(EVT VT, AttributeSet Attr) const override; SDValue LowerCall(CallLoweringInfo &CLI, SmallVectorImpl<SDValue> &InVals) const override; diff --git a/llvm/test/CodeGen/WebAssembly/divrem-constant.ll b/llvm/test/CodeGen/WebAssembly/divrem-constant.ll new file mode 100644 index 00000000000..6150cab4d4f --- /dev/null +++ b/llvm/test/CodeGen/WebAssembly/divrem-constant.ll @@ -0,0 +1,62 @@ +; RUN: llc < %s -asm-verbose=false | FileCheck %s + +; Test that integer div and rem by constant are optimized appropriately. + +target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" +target triple = "wasm32-unknown-unknown" + +; CHECK-LABEL: test_udiv_2: +; CHECK: i32.shr_u +define i32 @test_udiv_2(i32 %x) { + %t = udiv i32 %x, 2 + ret i32 %t +} + +; CHECK-LABEL: test_udiv_5: +; CHECK: i32.div_u +define i32 @test_udiv_5(i32 %x) { + %t = udiv i32 %x, 5 + ret i32 %t +} + +; CHECK-LABEL: test_sdiv_2: +; CHECK: i32.div_s +define i32 @test_sdiv_2(i32 %x) { + %t = sdiv i32 %x, 2 + ret i32 %t +} + +; CHECK-LABEL: test_sdiv_5: +; CHECK: i32.div_s +define i32 @test_sdiv_5(i32 %x) { + %t = sdiv i32 %x, 5 + ret i32 %t +} + +; CHECK-LABEL: test_urem_2: +; CHECK: i32.and +define i32 @test_urem_2(i32 %x) { + %t = urem i32 %x, 2 + ret i32 %t +} + +; CHECK-LABEL: test_urem_5: +; CHECK: i32.rem_u +define i32 @test_urem_5(i32 %x) { + %t = urem i32 %x, 5 + ret i32 %t +} + +; CHECK-LABEL: test_srem_2: +; CHECK: i32.rem_s +define i32 @test_srem_2(i32 %x) { + %t = srem i32 %x, 2 + ret i32 %t +} + +; CHECK-LABEL: test_srem_5: +; CHECK: i32.rem_s +define i32 @test_srem_5(i32 %x) { + %t = srem i32 %x, 5 + ret i32 %t +} |