summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian McCarthy <amccarth@google.com>2017-03-15 20:29:06 +0000
committerAdrian McCarthy <amccarth@google.com>2017-03-15 20:29:06 +0000
commitad6d60a46bd9a1eaed2e79cc68aaec095109d625 (patch)
treea5165e448039f327bce826f7253880ae686c68c5
parentf1e1fba1b0354f9b82e6e26de7e88ec5cd3a9c32 (diff)
downloadbcm5719-llvm-ad6d60a46bd9a1eaed2e79cc68aaec095109d625.tar.gz
bcm5719-llvm-ad6d60a46bd9a1eaed2e79cc68aaec095109d625.zip
NFC: Corrects comments that were supposed to go in with earlier commit.
llvm-svn: 297887
-rw-r--r--llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp b/llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
index 24b62823eb2..9c0cc0bf823 100644
--- a/llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
@@ -1,4 +1,4 @@
-//===- NativeCompilandSymbol.h - Native impl of PDBCompilandSymbol -C++ -*-===//
+//===- NativeCompilandSymbol.cpp - Native impl for compilands ---*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
@@ -26,9 +26,10 @@ bool NativeCompilandSymbol::isEditAndContinueEnabled() const {
uint32_t NativeCompilandSymbol::getLexicalParentId() const { return 0; }
-// DIA, which this API was modeled after, uses counter-intuitive meanings for
-// IDiaSymbol::get_name and IDiaSymbol::get_libraryName, which is why these
-// methods may appear to be cross-mapped.
+// The usage of getObjFileName for getLibraryName and getModuleName for getName
+// may seem backwards, but it is consistent with DIA, which is what this API
+// was modeled after. We may rename these methods later to try to eliminate
+// this potential confusion.
std::string NativeCompilandSymbol::getLibraryName() const {
return Module.Info.getObjFileName();
OpenPOWER on IntegriCloud