Fix warnings in FunctionTest.cpp.

Because of the goop involved in the EXPECT_EQ macro, we were getting the
following warning

  expression with side effects has no effect in an unevaluated context

because the "I++" was being used inside of a template type:

  switch (0) case 0: default: if (const ::testing::AssertionResult gtest_ar = (::testing::internal:: EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(Args[I++])) == 1)>::Compare("Args[I++]", "&A", Args[I++], &A))) ; else ::testing::internal::AssertHelper(::testing::TestPartResult::kNonFatalFailure, "../src/unittests/IR/FunctionTest.cpp", 94, gtest_ar.failure_message()) = ::testing::Message();

llvm-svn: 275291

1 files changed, 12 insertions, 6 deletions

diff --git a/llvm/unittests/IR/FunctionTest.cpp b/llvm/unittests/IR/FunctionTest.cpp
index 8dd1f2bb00b..fb458597c37 100644
--- a/llvm/unittests/IR/FunctionTest.cpp
+++ b/llvm/unittests/IR/FunctionTest.cpp
@@ -70,15 +70,19 @@ TEST(FunctionTest, stealArgumentListFrom) {
   EXPECT_TRUE(F1->hasLazyArguments());
   EXPECT_FALSE(F2->hasLazyArguments());
   unsigned I = 0;
-  for (Argument &A : F2->args())
-    EXPECT_EQ(Args[I++], &A);
+  for (Argument &A : F2->args()) {
+    EXPECT_EQ(Args[I], &A);
+    I++;
+  }
   EXPECT_EQ(2u, I);
 
   // Check that arguments in F1 don't have pointer equality with the saved ones.
   // This also instantiates F1's arguments.
   I = 0;
-  for (Argument &A : F1->args())
-    EXPECT_NE(Args[I++], &A);
+  for (Argument &A : F1->args()) {
+    EXPECT_NE(Args[I], &A);
+    I++;
+  }
   EXPECT_EQ(2u, I);
   EXPECT_FALSE(F1->hasLazyArguments());
   EXPECT_FALSE(F2->hasLazyArguments());
@@ -90,8 +94,10 @@ TEST(FunctionTest, stealArgumentListFrom) {
   EXPECT_FALSE(F1->hasLazyArguments());
   EXPECT_TRUE(F2->hasLazyArguments());
   I = 0;
-  for (Argument &A : F1->args())
-    EXPECT_EQ(Args[I++], &A);
+  for (Argument &A : F1->args()) {
+    EXPECT_EQ(Args[I], &A);
+    I++;
+  }
   EXPECT_EQ(2u, I);
 
   // Steal from F2 a second time.  Now both functions should have lazy