summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChen Zheng <czhengsz@cn.ibm.com>2019-06-26 12:02:43 +0000
committerChen Zheng <czhengsz@cn.ibm.com>2019-06-26 12:02:43 +0000
commitaa999528966781ae84e508b5a29cc4be7ea0368f (patch)
tree7e64cccd27618d5ea8959538ad0ce218ae0471dd
parent6876de90e8e8931b9918702e18c4854d7b2ed05c (diff)
downloadbcm5719-llvm-aa999528966781ae84e508b5a29cc4be7ea0368f.tar.gz
bcm5719-llvm-aa999528966781ae84e508b5a29cc4be7ea0368f.zip
[HardwareLoops] NFC - move loop with irreducible control flow checking logic to HarewareLoopInfo.
llvm-svn: 364415
-rw-r--r--llvm/include/llvm/Analysis/TargetTransformInfo.h4
-rw-r--r--llvm/lib/Analysis/TargetTransformInfo.cpp18
-rw-r--r--llvm/lib/CodeGen/HardwareLoops.cpp5
3 files changed, 17 insertions, 10 deletions
diff --git a/llvm/include/llvm/Analysis/TargetTransformInfo.h b/llvm/include/llvm/Analysis/TargetTransformInfo.h
index c5dbd956bea..1e41fd584c6 100644
--- a/llvm/include/llvm/Analysis/TargetTransformInfo.h
+++ b/llvm/include/llvm/Analysis/TargetTransformInfo.h
@@ -96,6 +96,7 @@ struct HardwareLoopInfo {
bool isHardwareLoopCandidate(ScalarEvolution &SE, LoopInfo &LI,
DominatorTree &DT, bool ForceNestedLoop = false,
bool ForceHardwareLoopPHI = false);
+ bool canAnalyze(LoopInfo &LI);
};
/// This pass provides access to the codegen interfaces that are needed
@@ -473,8 +474,7 @@ public:
/// Query the target whether it would be profitable to convert the given loop
/// into a hardware loop.
- bool isHardwareLoopProfitable(Loop *L, LoopInfo &LI,
- ScalarEvolution &SE,
+ bool isHardwareLoopProfitable(Loop *L, ScalarEvolution &SE,
AssumptionCache &AC,
TargetLibraryInfo *LibInfo,
HardwareLoopInfo &HWLoopInfo) const;
diff --git a/llvm/lib/Analysis/TargetTransformInfo.cpp b/llvm/lib/Analysis/TargetTransformInfo.cpp
index 5fde3443457..6dbdaeeae5f 100644
--- a/llvm/lib/Analysis/TargetTransformInfo.cpp
+++ b/llvm/lib/Analysis/TargetTransformInfo.cpp
@@ -42,6 +42,16 @@ struct NoTTIImpl : TargetTransformInfoImplCRTPBase<NoTTIImpl> {
};
}
+bool HardwareLoopInfo::canAnalyze(LoopInfo &LI) {
+ // If the loop has irreducible control flow, it can not be converted to
+ // Hardware loop.
+ LoopBlocksRPO RPOT(L);
+ RPOT.perform(&LI);
+ if (containsIrreducibleCFG<const BasicBlock *>(RPOT, LI))
+ return false;
+ return true;
+}
+
bool HardwareLoopInfo::isHardwareLoopCandidate(ScalarEvolution &SE,
LoopInfo &LI, DominatorTree &DT,
bool ForceNestedLoop,
@@ -218,14 +228,8 @@ bool TargetTransformInfo::isLoweredToCall(const Function *F) const {
}
bool TargetTransformInfo::isHardwareLoopProfitable(
- Loop *L, LoopInfo &LI, ScalarEvolution &SE, AssumptionCache &AC,
+ Loop *L, ScalarEvolution &SE, AssumptionCache &AC,
TargetLibraryInfo *LibInfo, HardwareLoopInfo &HWLoopInfo) const {
- // If the loop has irreducible control flow, it can not be converted to
- // Hardware loop.
- LoopBlocksRPO RPOT(L);
- RPOT.perform(&LI);
- if (containsIrreducibleCFG<const BasicBlock *>(RPOT, LI))
- return false;
return TTIImpl->isHardwareLoopProfitable(L, SE, AC, LibInfo, HWLoopInfo);
}
diff --git a/llvm/lib/CodeGen/HardwareLoops.cpp b/llvm/lib/CodeGen/HardwareLoops.cpp
index 3d900e3b7f5..8bf973a7ead 100644
--- a/llvm/lib/CodeGen/HardwareLoops.cpp
+++ b/llvm/lib/CodeGen/HardwareLoops.cpp
@@ -198,7 +198,10 @@ bool HardwareLoops::TryConvertLoop(Loop *L) {
return true; // Stop search.
HardwareLoopInfo HWLoopInfo(L);
- if (TTI->isHardwareLoopProfitable(L, *LI, *SE, *AC, LibInfo, HWLoopInfo) ||
+ if (!HWLoopInfo.canAnalyze(*LI))
+ return false;
+
+ if (TTI->isHardwareLoopProfitable(L, *SE, *AC, LibInfo, HWLoopInfo) ||
ForceHardwareLoops) {
// Allow overriding of the counter width and loop decrement value.
OpenPOWER on IntegriCloud