diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2019-01-26 21:29:16 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2019-01-26 21:29:16 +0000 |
| commit | a914fa4dd881af669dba66e68677116f0436d1ed (patch) | |
| tree | 3130891c92c4293b21cca7999b26f1a25bb9f138 | |
| parent | 64c3fe9103d05ed7f327c5559c3318187789033f (diff) | |
| download | bcm5719-llvm-a914fa4dd881af669dba66e68677116f0436d1ed.tar.gz bcm5719-llvm-a914fa4dd881af669dba66e68677116f0436d1ed.zip | |
[X86] combineAddOrSubToADCOrSBB/combineCarryThroughADD - use oneuse for entire SDNode
Fix issue noted in D57281 that only tested the one use for the SDValue (the result flag), not the entire SUB.
I've added the getNode() to make it clearer what is intended than just the -> redirection.
llvm-svn: 352291
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index fca0769f784..fcc7a67ba07 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -34901,7 +34901,8 @@ static SDValue combineCarryThroughADD(SDValue EFLAGS, SelectionDAG &DAG) { // Do not flip "e > c", where "c" is a constant, because Cmp // instruction cannot take an immediate as its first operand. // - if (CarryOp1.getOpcode() == X86ISD::SUB && CarryOp1.hasOneUse() && + if (CarryOp1.getOpcode() == X86ISD::SUB && + CarryOp1.getNode()->hasOneUse() && CarryOp1.getValueType().isInteger() && !isa<ConstantSDNode>(CarryOp1.getOperand(1))) { SDValue SubCommute = @@ -40716,7 +40717,7 @@ static SDValue combineAddOrSubToADCOrSBB(SDNode *N, SelectionDAG &DAG) { // Do not flip "e > c", where "c" is a constant, because Cmp instruction // cannot take an immediate as its first operand. // - if (EFLAGS.getOpcode() == X86ISD::SUB && EFLAGS.hasOneUse() && + if (EFLAGS.getOpcode() == X86ISD::SUB && EFLAGS.getNode()->hasOneUse() && EFLAGS.getValueType().isInteger() && !isa<ConstantSDNode>(EFLAGS.getOperand(1))) { SDValue NewSub = DAG.getNode(X86ISD::SUB, SDLoc(EFLAGS), |
