diff options
| author | Paul Robinson <paul.robinson@sony.com> | 2018-11-14 13:43:19 +0000 | 
|---|---|---|
| committer | Paul Robinson <paul.robinson@sony.com> | 2018-11-14 13:43:19 +0000 | 
| commit | a6a19c00d5058e0789777ee156def8d093108365 (patch) | |
| tree | a78148d3a2c220dee9d3f25958090439a807e8d0 | |
| parent | 02cb67deb9644f8df8665c856e3a84d1fd83eb92 (diff) | |
| download | bcm5719-llvm-a6a19c00d5058e0789777ee156def8d093108365.tar.gz bcm5719-llvm-a6a19c00d5058e0789777ee156def8d093108365.zip  | |
Document how to comment an actual parameter.
Differential Revision: https://reviews.llvm.org/D54446
llvm-svn: 346861
| -rw-r--r-- | llvm/docs/CodingStandards.rst | 15 | 
1 files changed, 15 insertions, 0 deletions
diff --git a/llvm/docs/CodingStandards.rst b/llvm/docs/CodingStandards.rst index 92cad91a08e..88d8ff804d9 100644 --- a/llvm/docs/CodingStandards.rst +++ b/llvm/docs/CodingStandards.rst @@ -305,6 +305,21 @@ useful to use C style (``/* */``) comments however:  #. When writing a source file that is used by a tool that only accepts C style     comments. +#. When documenting the significance of constants used as actual parameters in +   a call. This is most helpful for ``bool`` parameters, or passing ``0`` or +   ``nullptr``. Typically you add the formal parameter name, which ought to be +   meaningful. For example, it's not clear what the parameter means in this call: + +   .. code-block:: c++ + +     Object.emitName(nullptr); + +   An in-line C-style comment makes the intent obvious: + +   .. code-block:: c++ + +     Object.emitName(/*Prefix=*/nullptr); +  Commenting out large blocks of code is discouraged, but if you really have to do  this (for documentation purposes or as a suggestion for debug printing), use  ``#if 0`` and ``#endif``. These nest properly and are better behaved in general  | 

