summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnders Carlsson <andersca@mac.com>2010-10-31 01:21:47 +0000
committerAnders Carlsson <andersca@mac.com>2010-10-31 01:21:47 +0000
commita5df61a341ab35738a2788f222bd9799a060e2ea (patch)
treef2dd2eb823a21cdb178531b14ed0bf6be71a92ad
parent3fe87a1eed6c0470fa812902f47096dd6a5f204f (diff)
downloadbcm5719-llvm-a5df61a341ab35738a2788f222bd9799a060e2ea.tar.gz
bcm5719-llvm-a5df61a341ab35738a2788f222bd9799a060e2ea.zip
Don't try to evaluate the LHS or RHS of a member pointer binary operation. Fixes PR8507.
llvm-svn: 117850
-rw-r--r--clang/lib/AST/ExprConstant.cpp4
-rw-r--r--clang/test/CodeGenCXX/pointers-to-data-members.cpp11
2 files changed, 15 insertions, 0 deletions
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 715d30ead0c..61f5b136ac0 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -1966,6 +1966,10 @@ bool FloatExprEvaluator::VisitBinaryOperator(const BinaryOperator *E) {
return true;
}
+ // We can't evaluate pointer-to-member operations.
+ if (E->isPtrMemOp())
+ return false;
+
// FIXME: Diagnostics? I really don't understand how the warnings
// and errors are supposed to work.
APFloat RHS(0.0);
diff --git a/clang/test/CodeGenCXX/pointers-to-data-members.cpp b/clang/test/CodeGenCXX/pointers-to-data-members.cpp
index b2deb313287..41c76d0432b 100644
--- a/clang/test/CodeGenCXX/pointers-to-data-members.cpp
+++ b/clang/test/CodeGenCXX/pointers-to-data-members.cpp
@@ -206,3 +206,14 @@ namespace BoolPtrToMember {
return x.*member;
}
}
+
+namespace PR8507 {
+
+struct S;
+void f(S* p, double S::*pm) {
+ if (0 < p->*pm) {
+ }
+}
+
+}
+
OpenPOWER on IntegriCloud