diff options
| author | John McCall <rjmccall@apple.com> | 2013-02-19 01:57:29 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2013-02-19 01:57:29 +0000 |
| commit | a496098bb8bdbd9889e23bf1363ca28376ed7113 (patch) | |
| tree | 5e997d7bc0499b14bb4045fdc2c7e5bb97badeb8 | |
| parent | eac4a48d23c4cc396107f504c0944662328eec58 (diff) | |
| download | bcm5719-llvm-a496098bb8bdbd9889e23bf1363ca28376ed7113.tar.gz bcm5719-llvm-a496098bb8bdbd9889e23bf1363ca28376ed7113.zip | |
Use the actual class visibility for the ObjC EHTYPE global,
not the global visibility mode.
Noticed by inspection.
llvm-svn: 175479
| -rw-r--r-- | clang/lib/CodeGen/CGObjCMac.cpp | 2 | ||||
| -rw-r--r-- | clang/test/CodeGenObjC/attr-exception.m | 27 |
2 files changed, 28 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp index b6617a0557b..bea30a13673 100644 --- a/clang/lib/CodeGen/CGObjCMac.cpp +++ b/clang/lib/CodeGen/CGObjCMac.cpp @@ -7054,7 +7054,7 @@ CGObjCNonFragileABIMac::GetInterfaceEHType(const ObjCInterfaceDecl *ID, ID->getIdentifier()->getName())); } - if (CGM.getLangOpts().getVisibilityMode() == HiddenVisibility) + if (ID->getVisibility() == HiddenVisibility) Entry->setVisibility(llvm::GlobalValue::HiddenVisibility); Entry->setAlignment(CGM.getDataLayout().getABITypeAlignment( ObjCTypes.EHTypeTy)); diff --git a/clang/test/CodeGenObjC/attr-exception.m b/clang/test/CodeGenObjC/attr-exception.m new file mode 100644 index 00000000000..4d8c425769d --- /dev/null +++ b/clang/test/CodeGenObjC/attr-exception.m @@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -emit-llvm -fexceptions -fobjc-exceptions -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -emit-llvm -fexceptions -fobjc-exceptions -fvisibility hidden -o - %s | FileCheck -check-prefix=CHECK-HIDDEN %s + +__attribute__((objc_root_class)) +@interface Root { + Class isa; +} +@end + +__attribute__((objc_exception)) +@interface A : Root +@end + +@implementation A +@end +// CHECK: @"OBJC_EHTYPE_$_A" = global {{%.*}} { i8** getelementptr (i8** @objc_ehtype_vtable, i32 2) +// CHECK-HIDDEN: @"OBJC_EHTYPE_$_A" = hidden global {{%.*}} { i8** getelementptr (i8** @objc_ehtype_vtable, i32 2) + +__attribute__((objc_exception)) +__attribute__((visibility("default"))) +@interface B : Root +@end + +@implementation B +@end +// CHECK: @"OBJC_EHTYPE_$_B" = global {{%.*}} { i8** getelementptr (i8** @objc_ehtype_vtable, i32 2) +// CHECK-HIDDEN: @"OBJC_EHTYPE_$_B" = global {{%.*}} { i8** getelementptr (i8** @objc_ehtype_vtable, i32 2) |
