summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWill Dietz <wdietz2@illinois.edu>2013-01-10 22:20:02 +0000
committerWill Dietz <wdietz2@illinois.edu>2013-01-10 22:20:02 +0000
commita38608b43f85245135e4b5b846b458dd9c5f937f (patch)
treef41afefaaf5ce85ae728cd2c00a7f77ecd11c476
parent54c3907484d05b4b6e0dd154f2e08a5fa0574f39 (diff)
downloadbcm5719-llvm-a38608b43f85245135e4b5b846b458dd9c5f937f.tar.gz
bcm5719-llvm-a38608b43f85245135e4b5b846b458dd9c5f937f.zip
ToolChains: Minor touchup to use correct type, avoid truncation.
Truncation happens regularly when find_first_not_of returns npos, strings long enough to trigger bug here are implausible. No functionality change intended (ignoring absurd string lengths). llvm-svn: 172127
-rw-r--r--clang/lib/Driver/ToolChains.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Driver/ToolChains.cpp b/clang/lib/Driver/ToolChains.cpp
index fa217605e9e..03a01e3402f 100644
--- a/clang/lib/Driver/ToolChains.cpp
+++ b/clang/lib/Driver/ToolChains.cpp
@@ -952,7 +952,7 @@ Generic_GCC::GCCVersion Linux::GCCVersion::Parse(StringRef VersionText) {
// And retains any patch number it finds.
StringRef PatchText = GoodVersion.PatchSuffix = Second.second.str();
if (!PatchText.empty()) {
- if (unsigned EndNumber = PatchText.find_first_not_of("0123456789")) {
+ if (size_t EndNumber = PatchText.find_first_not_of("0123456789")) {
// Try to parse the number and any suffix.
if (PatchText.slice(0, EndNumber).getAsInteger(10, GoodVersion.Patch) ||
GoodVersion.Patch < 0)
OpenPOWER on IntegriCloud