diff options
| author | Roman Lebedev <lebedev.ri@gmail.com> | 2019-09-25 22:59:59 +0000 |
|---|---|---|
| committer | Roman Lebedev <lebedev.ri@gmail.com> | 2019-09-25 22:59:59 +0000 |
| commit | a2fa03af3ab961e718d295c6dbdbde3ac4ae8dd8 (patch) | |
| tree | e097a7fb6887091ed4a1bfa1f379dab3de4f0d0f | |
| parent | ca524621d14cd35c4cc226e53ccf3be403bdfc37 (diff) | |
| download | bcm5719-llvm-a2fa03af3ab961e718d295c6dbdbde3ac4ae8dd8.tar.gz bcm5719-llvm-a2fa03af3ab961e718d295c6dbdbde3ac4ae8dd8.zip | |
[InstCombine] foldUnsignedUnderflowCheck(): one last pattern with 'sub' (PR43251)
https://rise4fun.com/Alive/0j9
llvm-svn: 372930
| -rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp | 10 | ||||
| -rw-r--r-- | llvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll | 12 |
2 files changed, 14 insertions, 8 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp index 6252e5d15a1..db5095b6fea 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -1128,6 +1128,16 @@ static Value *foldUnsignedUnderflowCheck(ICmpInst *ZeroICmp, EqPred == ICmpInst::ICMP_EQ && !IsAnd) return Builder.CreateICmpULE(Base, Offset); + // Base <= Offset && (Base - Offset) != 0 --> Base < Offset + if (UnsignedPred == ICmpInst::ICMP_ULE && EqPred == ICmpInst::ICMP_NE && + IsAnd) + return Builder.CreateICmpULT(Base, Offset); + + // Base > Offset || (Base - Offset) == 0 --> Base >= Offset + if (UnsignedPred == ICmpInst::ICMP_UGT && EqPred == ICmpInst::ICMP_EQ && + !IsAnd) + return Builder.CreateICmpUGE(Base, Offset); + return nullptr; } diff --git a/llvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll b/llvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll index ad60ad98788..d46da5ec863 100644 --- a/llvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll +++ b/llvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll @@ -404,10 +404,8 @@ define i1 @base_ult_offset(i8 %base, i8 %offset) { ; CHECK-LABEL: @base_ult_offset( ; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]] ; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]]) -; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0 -; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ule i8 [[BASE]], [[OFFSET]] -; CHECK-NEXT: [[R:%.*]] = and i1 [[NO_UNDERFLOW]], [[NOT_NULL]] -; CHECK-NEXT: ret i1 [[R]] +; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i8 [[BASE]], [[OFFSET]] +; CHECK-NEXT: ret i1 [[TMP1]] ; %adjusted = sub i8 %base, %offset call void @use8(i8 %adjusted) @@ -420,10 +418,8 @@ define i1 @base_uge_offset(i8 %base, i8 %offset) { ; CHECK-LABEL: @base_uge_offset( ; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]] ; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]]) -; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0 -; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ugt i8 [[BASE]], [[OFFSET]] -; CHECK-NEXT: [[R:%.*]] = or i1 [[NO_UNDERFLOW]], [[NOT_NULL]] -; CHECK-NEXT: ret i1 [[R]] +; CHECK-NEXT: [[TMP1:%.*]] = icmp uge i8 [[BASE]], [[OFFSET]] +; CHECK-NEXT: ret i1 [[TMP1]] ; %adjusted = sub i8 %base, %offset call void @use8(i8 %adjusted) |
