summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHaojian Wu <hokein.wu@gmail.com>2019-12-10 21:13:36 +0100
committerHaojian Wu <hokein.wu@gmail.com>2019-12-10 21:23:13 +0100
commita2602bdd7316e3e41366f946a83a5a654b909957 (patch)
treecc1fece1c631d42e449b1bf8aa3834c5769b70d4
parentb6d386f6f996394ec24c5d0ebe84131c89237594 (diff)
downloadbcm5719-llvm-a2602bdd7316e3e41366f946a83a5a654b909957.tar.gz
bcm5719-llvm-a2602bdd7316e3e41366f946a83a5a654b909957.zip
[clangd] Fix an incorrect expectedResult usage in rename test.
expectedResult(Code, expectedResult(T, "abc")) => should be expectedResult(T, "abc") The test was passed by coincidence.
-rw-r--r--clang-tools-extra/clangd/unittests/RenameTests.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp
index bce73f09fce..fc2b6fe62cb 100644
--- a/clang-tools-extra/clangd/unittests/RenameTests.cpp
+++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp
@@ -832,7 +832,8 @@ TEST(CrossFileRenameTests, BuildRenameEdits) {
Annotations Code("[[😂]]");
auto LSPRange = Code.range();
llvm::StringRef FilePath = "/test/TestTU.cpp";
- auto Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, "abc");
+ llvm::StringRef NewName = "abc";
+ auto Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, NewName);
ASSERT_TRUE(bool(Edit)) << Edit.takeError();
ASSERT_EQ(1UL, Edit->Replacements.size());
EXPECT_EQ(FilePath, Edit->Replacements.begin()->getFilePath());
@@ -840,7 +841,7 @@ TEST(CrossFileRenameTests, BuildRenameEdits) {
// Test invalid range.
LSPRange.end = {10, 0}; // out of range
- Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, "abc");
+ Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, NewName);
EXPECT_FALSE(Edit);
EXPECT_THAT(llvm::toString(Edit.takeError()),
testing::HasSubstr("fail to convert"));
@@ -851,10 +852,10 @@ TEST(CrossFileRenameTests, BuildRenameEdits) {
[[range]]
[[range]]
)cpp");
- Edit = buildRenameEdit(FilePath, T.code(), T.ranges(), "abc");
+ Edit = buildRenameEdit(FilePath, T.code(), T.ranges(), NewName);
ASSERT_TRUE(bool(Edit)) << Edit.takeError();
EXPECT_EQ(applyEdits(FileEdits{{T.code(), std::move(*Edit)}}).front().second,
- expectedResult(Code, expectedResult(T, "abc")));
+ expectedResult(T, NewName));
}
TEST(CrossFileRenameTests, adjustRenameRanges) {
OpenPOWER on IntegriCloud