diff options
| author | Karl-Johan Karlsson <karl-johan.karlsson@ericsson.com> | 2019-09-16 09:52:23 +0000 |
|---|---|---|
| committer | Karl-Johan Karlsson <karl-johan.karlsson@ericsson.com> | 2019-09-16 09:52:23 +0000 |
| commit | a1bc428b897900eb562df45622f01e6f94329dda (patch) | |
| tree | 52c26a57dd73634b7cd57ab762b9d9d6f2d0358d | |
| parent | 3716547c5fe31115cf648950df201491c1858035 (diff) | |
| download | bcm5719-llvm-a1bc428b897900eb562df45622f01e6f94329dda.tar.gz bcm5719-llvm-a1bc428b897900eb562df45622f01e6f94329dda.zip | |
Change signature of __builtin_rotateright64 back to unsigned
The signature of __builtin_rotateright64 was by misstake changed from
unsigned to signed in r360863, this patch will change it back to
unsigned as intended.
This fixes pr43309
Reviewers: efriedma, hans
Reviewed By: hans
Differential Revision: https://reviews.llvm.org/D67606
llvm-svn: 371969
| -rw-r--r-- | clang/include/clang/Basic/Builtins.def | 2 | ||||
| -rw-r--r-- | clang/test/CodeGen/avr-builtins.c | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/clang/include/clang/Basic/Builtins.def b/clang/include/clang/Basic/Builtins.def index c1fcd9bb306..6dd0d3a7310 100644 --- a/clang/include/clang/Basic/Builtins.def +++ b/clang/include/clang/Basic/Builtins.def @@ -461,7 +461,7 @@ BUILTIN(__builtin_rotateleft64, "UWiUWiUWi", "nc") BUILTIN(__builtin_rotateright8, "UcUcUc", "nc") BUILTIN(__builtin_rotateright16, "UsUsUs", "nc") BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc") -BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc") +BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc") // Random GCC builtins BUILTIN(__builtin_constant_p, "i.", "nctu") diff --git a/clang/test/CodeGen/avr-builtins.c b/clang/test/CodeGen/avr-builtins.c index cbba6b2f2a2..8fa983a7823 100644 --- a/clang/test/CodeGen/avr-builtins.c +++ b/clang/test/CodeGen/avr-builtins.c @@ -1,5 +1,9 @@ // RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s +// Check that the parameter types match. This verifies pr43309. +// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s +// expected-no-diagnostics + unsigned char bitrev8(unsigned char data) { return __builtin_bitreverse8(data); } |
