summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTed Kremenek <kremenek@apple.com>2010-08-05 15:03:30 +0000
committerTed Kremenek <kremenek@apple.com>2010-08-05 15:03:30 +0000
commit9c22219d9c4a6f9d5f71df850f7e68fd631025d4 (patch)
treece193e3132ed615de513a6479abfbc3630bb0e8c
parent06dcfd94c8f3422ffdb4c843b55bcda042851af6 (diff)
downloadbcm5719-llvm-9c22219d9c4a6f9d5f71df850f7e68fd631025d4.tar.gz
bcm5719-llvm-9c22219d9c4a6f9d5f71df850f7e68fd631025d4.zip
Revert r110317, and add a comment why the assertion is not an invariant.
llvm-svn: 110330
-rw-r--r--clang/lib/Checker/GRExprEngine.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/Checker/GRExprEngine.cpp b/clang/lib/Checker/GRExprEngine.cpp
index d4ee0efb54b..4ecc75f105d 100644
--- a/clang/lib/Checker/GRExprEngine.cpp
+++ b/clang/lib/Checker/GRExprEngine.cpp
@@ -236,11 +236,11 @@ void GRExprEngine::CheckerVisit(const Stmt *S, ExplodedNodeSet &Dst,
// If we built NewCO, check if we called all the checkers. This is important
// so that we know that we accurately determined the entire set of checkers
- // that responds to this callback.
- if (NewCO.get()) {
- assert(checkersEvaluated == Checkers.size());
+ // that responds to this callback. Note that 'checkersEvaluated' might
+ // not be the same as Checkers.size() if one of the Checkers generates
+ // a sink node.
+ if (NewCO.get() && checkersEvaluated == Checkers.size())
CO_Ref = NewCO.take();
- }
// Don't autotransition. The CheckerContext objects should do this
// automatically.
OpenPOWER on IntegriCloud