diff options
| author | Jason Molenda <jmolenda@apple.com> | 2014-10-17 01:55:08 +0000 |
|---|---|---|
| committer | Jason Molenda <jmolenda@apple.com> | 2014-10-17 01:55:08 +0000 |
| commit | 9bdc4e1a59a89b35d6625057b4e91fe8b7073756 (patch) | |
| tree | 8e86fd1d2af94bcbb7e58148d62a60b2158f1e69 | |
| parent | 93a13de304371dece5d57bd43831e77b6a14d4e4 (diff) | |
| download | bcm5719-llvm-9bdc4e1a59a89b35d6625057b4e91fe8b7073756.tar.gz bcm5719-llvm-9bdc4e1a59a89b35d6625057b4e91fe8b7073756.zip | |
Add null-checks around getter/setter before using them.
clang static analyzer fixit.
llvm-svn: 220024
| -rw-r--r-- | lldb/source/Symbol/ClangASTType.cpp | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/lldb/source/Symbol/ClangASTType.cpp b/lldb/source/Symbol/ClangASTType.cpp index e35d2af7bba..d8e053d0940 100644 --- a/lldb/source/Symbol/ClangASTType.cpp +++ b/lldb/source/Symbol/ClangASTType.cpp @@ -5370,9 +5370,12 @@ ClangASTType::AddObjCClassProperty (const char *property_name, if (getter && metadata) ClangASTContext::SetMetadata(m_ast, getter, *metadata); - getter->setMethodParams(*m_ast, llvm::ArrayRef<clang::ParmVarDecl*>(), llvm::ArrayRef<clang::SourceLocation>()); + if (getter) + { + getter->setMethodParams(*m_ast, llvm::ArrayRef<clang::ParmVarDecl*>(), llvm::ArrayRef<clang::SourceLocation>()); - class_interface_decl->addDecl(getter); + class_interface_decl->addDecl(getter); + } } if (!setter_sel.isNull() && !class_interface_decl->lookupInstanceMethod(setter_sel)) @@ -5417,9 +5420,12 @@ ClangASTType::AddObjCClassProperty (const char *property_name, clang::SC_Auto, nullptr)); - setter->setMethodParams(*m_ast, llvm::ArrayRef<clang::ParmVarDecl*>(params), llvm::ArrayRef<clang::SourceLocation>()); + if (setter) + { + setter->setMethodParams(*m_ast, llvm::ArrayRef<clang::ParmVarDecl*>(params), llvm::ArrayRef<clang::SourceLocation>()); - class_interface_decl->addDecl(setter); + class_interface_decl->addDecl(setter); + } } return true; |
