summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2017-08-09 16:00:31 +0000
committerAlexander Kornienko <alexfh@google.com>2017-08-09 16:00:31 +0000
commit9b8df6ae025ff6553b62f64b8c69f0383dbc8ef2 (patch)
tree8679513f19e94e80309556e389bb0a84de32cb9c
parent6f80d6b46f394f033a290aa5a2ecd32784b9e786 (diff)
downloadbcm5719-llvm-9b8df6ae025ff6553b62f64b8c69f0383dbc8ef2.tar.gz
bcm5719-llvm-9b8df6ae025ff6553b62f64b8c69f0383dbc8ef2.zip
[clang-tidy] Ignore newlines in checks list
This is a follow up to https://reviews.llvm.org/D30567 where I overlooked that LLVM YAML parser doesn't support multiline literal folding. llvm-svn: 310491
-rw-r--r--clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp2
-rw-r--r--clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
index 07933113e00..44f78b8ac74 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
@@ -115,7 +115,7 @@ ClangTidyError::ClangTidyError(StringRef CheckName,
// Returns true if GlobList starts with the negative indicator ('-'), removes it
// from the GlobList.
static bool ConsumeNegativeIndicator(StringRef &GlobList) {
- GlobList = GlobList.trim(' ');
+ GlobList = GlobList.trim(" \r\n");
if (GlobList.startswith("-")) {
GlobList = GlobList.substr(1);
return true;
diff --git a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
index 0ee800d7fb8..5547f98ffd0 100644
--- a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
+++ b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
@@ -74,7 +74,7 @@ TEST(GlobList, WhitespacesAtBegin) {
}
TEST(GlobList, Complex) {
- GlobList Filter("*,-a.*, -b.*, a.1.* ,-a.1.A.*,-..,-...,-..+,-*$, -*qwe* ");
+ GlobList Filter("*,-a.*, -b.*, \r \n a.1.* ,-a.1.A.*,-..,-...,-..+,-*$, -*qwe* ");
EXPECT_TRUE(Filter.contains("aaa"));
EXPECT_TRUE(Filter.contains("qqq"));
OpenPOWER on IntegriCloud