diff options
| author | Felix Berger <flx@google.com> | 2016-05-03 23:07:44 +0000 |
|---|---|---|
| committer | Felix Berger <flx@google.com> | 2016-05-03 23:07:44 +0000 |
| commit | 99a0dddb3a7c8068db6913c610ee6cde79a6368b (patch) | |
| tree | dc1e1a10a7d487e17cd824bd1ba7702f39f10a37 | |
| parent | af09f4ac7296ad7a3539c114151f2c520d091637 (diff) | |
| download | bcm5719-llvm-99a0dddb3a7c8068db6913c610ee6cde79a6368b.tar.gz bcm5719-llvm-99a0dddb3a7c8068db6913c610ee6cde79a6368b.zip | |
[clang-tidy] MoveConstructorInitCheck - Add parameter name to check message.
Reviewers: alexfh
Subscribers: aaron.ballman, cfe-commits
Differential Revision: http://reviews.llvm.org/D19849
llvm-svn: 268461
| -rw-r--r-- | clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp | 5 | ||||
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp b/clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp index 7c1bc166201..79973990f0e 100644 --- a/clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp @@ -109,8 +109,9 @@ void MoveConstructorInitCheck::handleParamNotMoved( if (parmVarDeclRefExprOccurences(*MovableParam, *ConstructorDecl, *Result.Context) > 1) return; - auto DiagOut = - diag(InitArg->getLocStart(), "value argument can be moved to avoid copy"); + auto DiagOut = diag(InitArg->getLocStart(), + "value argument %0 can be moved to avoid copy") + << MovableParam; DiagOut << FixItHint::CreateReplacement( InitArg->getSourceRange(), (Twine("std::move(") + MovableParam->getName() + ")").str()); diff --git a/clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp b/clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp index 609dd082d29..55d309e75f1 100644 --- a/clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp +++ b/clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp @@ -96,7 +96,7 @@ struct TriviallyCopyable { struct Positive { Positive(Movable M) : M_(M) {} - // CHECK-MESSAGES: [[@LINE-1]]:28: warning: value argument can be moved to avoid copy [misc-move-constructor-init] + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: value argument 'M' can be moved to avoid copy [misc-move-constructor-init] // CHECK-FIXES: Positive(Movable M) : M_(std::move(M)) {} Movable M_; }; |

